[Broker][Proxy][Function worker] Remove duplicate servlet filter instances to fix backpressure #15637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
area/function
area/broker
area/proxy
doc-not-needed
lhotari
requested review from
codelipenghui,
eolivelli,
mattisonchao,
merlimat,
michaeljmarshall and
nicoloboschi
lhotari
force-pushed
the
lh-remove-duplicate-web-filters
branch
from
96316e2 to
e268d00
Compare
…r web server - There were filter instances for each context path which made maxConcurrentHttpRequests and httpRequestsMaxPerSecond not work as expected. - Fixes the backpressure solution that is dependent on maxConcurrentHttpRequests and httpRequestsMaxPerSecond working properly - Fix invalid Jersey api usage
lhotari
force-pushed
the
lh-remove-duplicate-web-filters
branch
from
e268d00 to
a9fbc37
Compare
michaeljmarshall
approved these changes
Jun 3, 2022
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java
Show resolved
Hide resolved
eolivelli
approved these changes
Jun 3, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
+1
Nice work.
I like the fact that we won't be doing classpath scanning anymore
4 tasks
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 24, 2024
…r web server (apache#15637) - There were filter instances for each context path which made maxConcurrentHttpRequests and httpRequestsMaxPerSecond not work as expected. - Fixes the backpressure solution that is dependent on maxConcurrentHttpRequests and httpRequestsMaxPerSecond working properly - Fix invalid Jersey api usage (cherry picked from commit 94392a4) Signed-off-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up on #14353
There were filter instances for each context path which made
maxConcurrentHttpRequestsandhttpRequestsMaxPerSecondconfiguration options not work as expected. The actual limits would be multiple times higher dependencing on the way clients access different context paths.Modifications
config.packages("jersey.config.server.provider.packages", javaPackages);is invalidjersey.config.server.provider.packagesdoesn't make any sense..registermethod should be used instead of registering the package which includes the individual resource class.