[improve][broker] Make some methods of ClusterBase pure async.
#15527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
May 16, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
May 16, 2022
pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java
Outdated
Show resolved
Hide resolved
Technoboy-
added
type/enhancement
Technoboy-
approved these changes
May 19, 2022
codelipenghui
approved these changes
May 20, 2022
26 tasks
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Apr 6, 2024
…me config ### Motivation apache#8976 introduced an `enableNamespaceIsolationUpdateOnTime` config, which is useless after apache#15527. This config actually does not make sense because it should always be true, while it's false by default just to keep the meaningless compatibility. ### Motivation Deprecate this config and strength the `brokerNamespaceIsolationPoliciesUpdateOnTime` test.
14 tasks
3 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Modifications
ClusterBasegetBrokerWithNamespaceIsolationPolicy/setNamespaceIsolationPolicyto pure async.Verifying this change
AdminTest#clustersalready cover this change.Documentation
no-need-doc(Please explain why)