Skip to content

Conversation

@michaeljmarshall
Copy link
Member

…thentication Methods (#12104)"

This reverts commit 5868025.

Master Issue: #12105

Motivation

Because the PIP is not completely implemented, we should not publish the interface changes in 2.10.

Modifications

  • Revert the core PR for PIP 97.

Verifying this change

This change is trivial, because the original change was completely backwards compatible.

Documentation

  • no-need-doc

@michaeljmarshall michaeljmarshall added the doc-not-needed Your PR changes do not impact docs label Feb 23, 2022
@michaeljmarshall michaeljmarshall added this to the 2.10.0 milestone Feb 23, 2022
@michaeljmarshall michaeljmarshall self-assigned this Feb 23, 2022
@michaeljmarshall
Copy link
Member Author

@codelipenghui - since we need to do a second RC for 2.10.0, I realized I should revert PIP 97 while I have the chance. I plan to complete the work soon, but it didn't make 2.10.

@michaeljmarshall
Copy link
Member Author

I am looking into why non of the tests ran.

@michaeljmarshall
Copy link
Member Author

@codelipenghui - I had opened this PR with the intention of making sure tests pass. Apparently, we don't have tests configured to run on these PRs--I thought we did. I am going to merge this now since I believe it is the correct change and will therefore get included in the next 2.10 RC.

@michaeljmarshall michaeljmarshall merged commit b822d6f into apache:branch-2.10 Feb 23, 2022
@michaeljmarshall michaeljmarshall deleted the revert-pip-97 branch February 23, 2022 05:38
@codelipenghui
Copy link
Contributor

codelipenghui commented Feb 24, 2022

@michaeljmarshall Ok, thanks for the update, any reason for reverting the change?

@michaeljmarshall
Copy link
Member Author

@codelipenghui - I reverted the commit that was responsible for updating the interfaces because none of the other work has been completed. It'd be a bit misleading for third parties to implement the interface since it is still synchronous. I plan to implement PIP 97 for Pulsar 2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants