[Broker] Fix NPE of internalExpireMessagesByTimestamp #14243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <[email protected]>
Jason918
approved these changes
Feb 12, 2022
mattisonchao
approved these changes
Feb 12, 2022
RobertIndie
approved these changes
Feb 12, 2022
liudezhi2098
approved these changes
Feb 14, 2022
hezhangjian
approved these changes
Feb 14, 2022
Demogorgon314
approved these changes
Feb 14, 2022
codelipenghui
approved these changes
Feb 14, 2022
Member
|
@codelipenghui @merlimat @Technoboy- @mattisonchao Why are the sync -> async changes made just before 2.10.0 release? This introduces new bugs as we can see once again. This bug fix is needed since #13880 introduced a new bug. |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation This issue was triggered by apache#13880, it doesn't handle the NPE in [here](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1R3502), we can check the [diff code](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1L3489) in apache#13880.
BewareMyPower
added a commit
that referenced
this pull request
Aug 1, 2022
Migrate the `setupDefaultTenantAndNamespace` method from #14243.
congbobo184
added
cherry-picked/branch-2.8
congbobo184
pushed a commit
that referenced
this pull request
Nov 11, 2022
This issue was triggered by #13880, it doesn't handle the NPE in [here](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1R3502), we can check the [diff code](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1L3489) in #13880. (cherry picked from commit a3c8525)
congbobo184
pushed a commit
that referenced
this pull request
Nov 26, 2022
This issue was triggered by #13880, it doesn't handle the NPE in [here](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1R3502), we can check the [diff code](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1L3489) in #13880. (cherry picked from commit a3c8525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This issue was triggered by #13880, it doesn't handle the NPE in here, we can check the diff code in #13880.
/cc @liudezhi2098
Modifications
ifinstead ofcheckNotNullVerifying this change
Documentation
no-need-doc- Fix the code