Skip to content

[Management] Make BrokerBase#deleteDynamicConfiguration to pure async method. #14163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 4 commits into from
Feb 9, 2022
Merged

[Management] Make BrokerBase#deleteDynamicConfiguration to pure async method. #14163

codelipenghui merged 4 commits into from
Feb 9, 2022

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Feb 8, 2022

Motivation

Make BrokerBase#deleteDynamicConfiguration to a pure async method to avoid some problems caused by sync and async methods calling each other.

Modifications

  • Make BrokerBase#deleteDynamicConfiguration to pure async method.
  • Use metadatainstead of zk in doc.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 8, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented Feb 8, 2022

@codelipenghui @lhotari @Technoboy- @Jason918 @RobertIndie @nodece

PTAL, when you have time ~ :)

nodece
nodece approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 8, 2022
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Feb 8, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented Feb 8, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit de6c539 into apache:master Feb 9, 2022
@lhotari
Copy link
Member

lhotari commented Feb 9, 2022

Make BrokerBase#deleteDynamicConfiguration to a pure async method to avoid some problems caused by sync and async methods calling each other.

@mattisonchao please share what these problems are. Is there a reported issue?
Since there are a lot of these sync -> async changes, it would be good to always open a discussion on the dev-mailing list to get a consensus of the problem that is being solved.
Could you start a dev-mailing list thread on the topic which describes the problem, the assumptions and the solution?

@lhotari lhotari mentioned this pull request Feb 14, 2022
Merged
2 tasks
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@mattisonchao
[Management] Make BrokerBase#deleteDynamicConfiguration to pure a…
bdf8f41 
…sync method. (apache#14163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@yuruguo yuruguo yuruguo approved these changes

@nodece nodece nodece approved these changes

Assignees

@mattisonchao mattisonchao

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

7 participants

@mattisonchao @lhotari @Jason918 @Technoboy- @codelipenghui @yuruguo @nodece