[Broker] Make PersistentTopicsBase#internalGetPartitionedMetadata async #14153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
RobertIndie
previously approved these changes
Feb 8, 2022
19 tasks
Technoboy-
force-pushed
the
getPartitionedMetadata-async
branch
from
f1bba01 to
4c440c7
Compare
mattisonchao
reviewed
Feb 9, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
Outdated
Show resolved
Hide resolved
|
The pr had no activity for 30 days, mark with Stale label. |
19 tasks
Technoboy-
force-pushed
the
getPartitionedMetadata-async
branch
from
483fc01 to
9b96827
Compare
Technoboy-
added
type/enhancement
mattisonchao
approved these changes
May 5, 2022
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
Overall LGTM, left some small comments.
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v1/V1_AdminApi2Test.java
Show resolved
Hide resolved
mattisonchao
approved these changes
May 5, 2022
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
@Technoboy- Thanks for your answer
congbobo184
approved these changes
May 5, 2022
Closed
Member
|
@Technoboy- Could you make a PR to branch-2.10? |
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make PersistentTopicsBase#internalGetPartitionedMetadata async.
Documentation
no-need-doc