Skip to content

[Broker]make grantPermissionsOnTopic method async #14152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 8 commits into from
Apr 24, 2022
Merged

[Broker]make grantPermissionsOnTopic method async #14152

codelipenghui merged 8 commits into from
Apr 24, 2022

Conversation

@liudezhi2098
Copy link
Contributor

@liudezhi2098 liudezhi2098 commented Feb 7, 2022

Master Issue: #14013

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalGrantPermissionsOnTopic.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 7, 2022
@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Feb 8, 2022

/pulsarbot run-failure-checks

@Technoboy- Technoboy- mentioned this pull request Feb 8, 2022
Closed
19 tasks
mattisonchao
mattisonchao reviewed Feb 9, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 12, 2022

The pr had no activity for 30 days, mark with Stale label.

@sijie sijie mentioned this pull request Mar 21, 2022
Open
19 tasks
@liudezhi2098 liudezhi2098 requested a review from Technoboy- April 20, 2022 11:16
Technoboy-
Technoboy- reviewed Apr 21, 2022
View reviewed changes
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
for (int i = 0; i < numPartitions; i++) {
TopicName topicNamePartition = topicName.getPartition(i);
future = future.thenCompose(unused -> grantPermissionsAsync(topicNamePartition, role,
actions));
Copy link
Contributor

@Technoboy- Technoboy- Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here will update zk, so it can't do concurrently.

Technoboy-
Technoboy- approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui added this to the 2.11.0 milestone Apr 24, 2022
@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Apr 24, 2022
@codelipenghui codelipenghui merged commit 1344b33 into apache:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattisonchao mattisonchao mattisonchao left review comments

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

Assignees

@liudezhi2098 liudezhi2098

Labels

area/broker doc-not-needed Your PR changes do not impact docs lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

5 participants

@liudezhi2098 @Technoboy- @codelipenghui @hezhangjian @mattisonchao