[Issue 14013] Make PersistentTopics#getPartitionedTopicList to pure async.
#14059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@codelipenghui @eolivelli @Technoboy- @Jason918 @shoothzj @RobertIndie @nodece PTAL, when you have time. :) |
19 tasks
mattisonchao
changed the title
PersistentTopics#getPartitionedTopicList to pure async.
gaozhangmin
requested changes
Feb 9, 2022
| } | ||
| return getPartitionedTopicList(TopicDomain.getEnum(domain())); | ||
| protected CompletableFuture<List<String>> internalGetPartitionedTopicList() { | ||
| return validateNamespaceOperationAsync(namespaceName, NamespaceOperation.GET_TOPICS) |
Contributor
There was a problem hiding this comment.
How about check namespaceExistsAsync before validateNamespaceOperationAsync
Technoboy-
reviewed
Feb 9, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Show resolved
Hide resolved
Technoboy-
reviewed
Feb 9, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Feb 9, 2022
Jason918
reviewed
Feb 9, 2022
| .get(config().getZooKeeperOperationTimeoutSeconds(), TimeUnit.SECONDS); | ||
| topics.addAll(getPartitionedTopicList(TopicDomain.persistent)); | ||
| topics.addAll(getPartitionedTopicList(TopicDomain.non_persistent)); | ||
| .get(timeoutSeconds, TimeUnit.SECONDS); |
Member
Author
There was a problem hiding this comment.
This is not the focus of this refactoring, it just affects here. And will keep the original code logic.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #14013
Motivation
Make Rest API
getPartitionedTopicListto async and to refactor code style to make it more clear.Modifications
getPartitionedTopicListmethod from sync to async.Verifying this change
Documentation
none.
Need to update docs?
no-need-doc