[Broker]make internalSkipMessages method async #14045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
I have two another suggestions:
- Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
- Have you checked to see if there is a test for the modified method ?
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Outdated
Show resolved
Hide resolved
Jason918
approved these changes
Jan 30, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
19 tasks
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Feb 7, 2022
2 tasks
19 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #14013
Motivation
Avoid call sync method in async rest API for PersistentTopicsBase#internalSkipMessages.
Modifications
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Need to update docs?
no-need-doc