[Broker] Make PersistentTopicsBase#internalCreateNonPartitionedTopic async. #14030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Technoboy-
changed the title
Technoboy-
changed the title
codelipenghui
previously approved these changes
Jan 29, 2022
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
Another, I have two suggestions:
- Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
- Have you checked to see if there is a test for the modified method?
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Yes, right. |
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
force-pushed
the
internalCreateNonPartitionedTopic-async
branch
from
1226a5e to
b4b3e56
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
19 tasks
Technoboy-
force-pushed
the
internalCreateNonPartitionedTopic-async
branch
from
a2a2e4d to
22c9b75
Compare
Technoboy-
added
type/enhancement
mattisonchao
approved these changes
May 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
force-pushed
the
internalCreateNonPartitionedTopic-async
branch
from
1ad69b8 to
dfc6c17
Compare
codelipenghui
approved these changes
May 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make PersistentTopicsBase#internalCreateNonPartitionedTopic async.
Documentation
no-need-doc