Skip to content

Using the consistent metadata store scheme name. #13937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 4 commits into from
Jan 27, 2022
Merged

Using the consistent metadata store scheme name. #13937

codelipenghui merged 4 commits into from
Jan 27, 2022

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Jan 25, 2022 •
edited
Loading

Using the consistent metadata store scheme name.

  • RocksDB -> rocksdb:
  • ZooKeeper -> zk:
  • Memory -> memory:
  • Ectd -> etcd:

Context: #13225 (comment)

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

@codelipenghui:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Jan 25, 2022

@codelipenghui:Thanks for providing doc info!

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 25, 2022
@codelipenghui codelipenghui force-pushed the penghui/consistent-metadata-url-identifier branch from 215152f to 68a3be5 Compare January 26, 2022 14:43
@codelipenghui codelipenghui merged commit 2762f2d into apache:master Jan 27, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@codelipenghui
Using the consistent metadata store scheme name. (apache#13937)
ae30eae 
Using the consistent metadata store scheme name.

- RocksDB -> rocksdb:
- ZooKeeper -> zk:
- Memory -> memory:
- Ectd -> etcd:

Context: apache#13225 (comment)
@codelipenghui codelipenghui deleted the penghui/consistent-metadata-url-identifier branch May 17, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@Jason918 Jason918 Jason918 approved these changes

@hangc0276 hangc0276 hangc0276 approved these changes

@jiazhai jiazhai jiazhai approved these changes

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@315157973 315157973 315157973 approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

Assignees

@codelipenghui codelipenghui

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

10 participants

@codelipenghui @merlimat @Jason918 @hangc0276 @jiazhai @gaozhangmin @315157973 @RobertIndie @Demogorgon314 @mattisonchao