Skip to content

[Issue 13854][broker] Fix call sync method in async rest api for internalDeleteSubscription #13884 #13917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 3 commits into from
Jan 24, 2022
Merged

[Issue 13854][broker] Fix call sync method in async rest api for internalDeleteSubscription #13884 #13917

codelipenghui merged 3 commits into from
Jan 24, 2022

Conversation

@codertmy
Copy link
Contributor

@codertmy codertmy commented Jan 24, 2022

Master Issue: #13854

Motivation

See #13854

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 24, 2022
@codertmy codertmy changed the title fix internalDeleteSubscription of PersistentTopicsBase to sync fix internalDeleteSubscription of PersistentTopicsBase to async Jan 24, 2022
@Jason918 Jason918 mentioned this pull request Jan 24, 2022
Closed
26 tasks
@codertmy codertmy changed the title fix internalDeleteSubscription of PersistentTopicsBase to async [Issue 13854][broker] Fix call sync method in async rest api for internalDeleteSubscription #13884 Jan 24, 2022
Jason918
Jason918 requested changes Jan 24, 2022
View reviewed changes
@Jason918
Copy link
Contributor

Jason918 commented Jan 24, 2022

@codelipenghui @mattisonchao @liudezhi2098 @gaozhangmin PTAL

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 24, 2022
@codelipenghui codelipenghui merged commit 4f194ac into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@codertmy codertmy

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@codertmy @Jason918 @codelipenghui