[Broker] Fix call sync method in async rest api for internalGetLastMessageId #13882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
changed the title
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
26 tasks
Jason918
reviewed
Jan 22, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
internalGetLastMessageId
branch
from
08cca65 to
b82cc5e
Compare
codelipenghui
approved these changes
Jan 24, 2022
Jason918
requested changes
Jan 24, 2022
| if (!(topic instanceof PersistentTopic)) { | ||
| log.error("[{}] Not supported operation of non-persistent topic {}", clientAppId(), topicName); | ||
| asyncResponse.resume(new RestException(Status.METHOD_NOT_ALLOWED, | ||
| "GetLastMessageId on a non-persistent topic is not allowed")); |
Jason918
approved these changes
Jan 24, 2022
Member
|
@gaozhangmin When submitting a PR, can you provide doc-related info (tick the box) in the PR description? So that Bot can recognize and label your PR correspondingly. Or else Bot labels your PR with You can check the instructions for doc labels here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13854
Motivation
Avoid call sync method in async rest API for PersistentTopicsBase#internalGetLastMessageId.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)