Skip to content

[Broker] Fix call sync method in async rest api for internalCreateSubscription. #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalCreateSubscription. #13873

codelipenghui merged 1 commit into from
Jan 24, 2022

Conversation

@Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jan 21, 2022

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalCreateSubscription.

Documentation

  • no-need-doc

@Technoboy- Technoboy- self-assigned this Jan 21, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 21, 2022
@mattisonchao mattisonchao mentioned this pull request Jan 21, 2022
Closed
26 tasks
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@codelipenghui codelipenghui merged commit d93d099 into apache:master Jan 24, 2022
@Technoboy- Technoboy- deleted the internalCreateSubscription-async branch August 10, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

Assignees

@Technoboy- Technoboy-

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Technoboy- @315157973 @codelipenghui @hezhangjian