Skip to content

[Broker] Fix call sync method in async rest api for internalGetBacklogSizeByMessageId #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 4 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalGetBacklogSizeByMessageId #13871

codelipenghui merged 4 commits into from
Jan 24, 2022

Conversation

@liudezhi2098
Copy link
Contributor

@liudezhi2098 liudezhi2098 commented Jan 21, 2022

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalGetBacklogSizeByMessageId.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 21, 2022
@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Jan 21, 2022

/pulsarbot run-failure-checks

1 similar comment
@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Jan 21, 2022

/pulsarbot run-failure-checks

@mattisonchao mattisonchao mentioned this pull request Jan 21, 2022
Closed
26 tasks
mattisonchao
mattisonchao reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comment.

@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Jan 21, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@codelipenghui codelipenghui merged commit b454639 into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattisonchao mattisonchao mattisonchao left review comments

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@liudezhi2098 liudezhi2098

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@liudezhi2098 @Jason918 @codelipenghui @mattisonchao