Skip to content

[Broker] Fix call sync method in async rest api for internalTriggerCompaction #13853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 5 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalTriggerCompaction #13853

codelipenghui merged 5 commits into from
Jan 24, 2022

Conversation

@liudezhi2098
Copy link
Contributor

@liudezhi2098 liudezhi2098 commented Jan 20, 2022 •
edited
Loading

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalTriggerCompaction.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-not-needed Your PR changes do not impact docs labels Jan 20, 2022
@mattisonchao mattisonchao mentioned this pull request Jan 20, 2022
Closed
26 tasks
@sijie sijie mentioned this pull request Jan 20, 2022
Closed
23 tasks
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Jan 21, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 42646fc into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattisonchao mattisonchao mattisonchao left review comments

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

Assignees

@liudezhi2098 liudezhi2098

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@liudezhi2098 @Jason918 @codelipenghui @hezhangjian @mattisonchao