Skip to content

[Broker] Fix call sync method in async rest api for internalGetSubscriptions #13846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 7 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalGetSubscriptions #13846

codelipenghui merged 7 commits into from
Jan 24, 2022

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jan 20, 2022

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalGetSubscriptions.

Modifications

  • Use async instead of sync method.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: ( no)
  • The schema: ( no )
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 20, 2022
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 20, 2022
@mattisonchao mattisonchao mentioned this pull request Jan 20, 2022
Closed
26 tasks
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 20, 2022

/pulsarbot rerun-failure-checks

@sijie sijie mentioned this pull request Jan 20, 2022
Closed
23 tasks
@mattisonchao mattisonchao requested a review from Jason918 January 24, 2022 09:09
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 24, 2022

@Jason918 PTAL :-)

@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 24, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit e0f8206 into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@Jason918 Jason918 Jason918 approved these changes

@315157973 315157973 315157973 approved these changes

Assignees

@mattisonchao mattisonchao

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mattisonchao @Jason918 @315157973 @codelipenghui