Skip to content

[Broker] Fix call sync method in async rest api for internalUnloadTopic #13845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 5 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalUnloadTopic #13845

codelipenghui merged 5 commits into from
Jan 24, 2022

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jan 20, 2022

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalUnloadTopic.

Modifications

  • Use async instead of sync method.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: ( no)
  • The schema: ( no )
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 20, 2022
codelipenghui
codelipenghui reviewed Jan 20, 2022
View reviewed changes
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
return null;
});
private void internalUnloadTransactionCoordinatorAsync(AsyncResponse asyncResponse, boolean authoritative) {
validateTopicOperationAsync(topicName, TopicOperation.UNLOAD)
Copy link
Contributor

@codelipenghui codelipenghui Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks like we make the wrong permission before, for the transaction coordinator, only the superuser can unload it. @congbobo184 Could you please help confirm?

Copy link
Contributor

@codelipenghui codelipenghui Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to push a separate PR to fix this one, to make this PR more focus on what it wants to do

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 20, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 20, 2022

/pulsarbot rerun-failure-checks

1 similar comment
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 20, 2022

/pulsarbot rerun-failure-checks

@mattisonchao mattisonchao mentioned this pull request Jan 20, 2022
Closed
26 tasks
@sijie sijie mentioned this pull request Jan 20, 2022
Closed
23 tasks
Jason918
Jason918 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 740c397 into apache:master Jan 24, 2022
@Technoboy- Technoboy- mentioned this pull request Apr 22, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@mattisonchao mattisonchao

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mattisonchao @Jason918 @codelipenghui