[PIP-143] Support split bundle by specified boundaries #13796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aloyszhang:Thanks for your contribution. For this PR, do we need to update docs? |
Member
|
Confirmed with @aloyszhang, since code is WIP, currently we do not know whether need to add docs or not, he will label this PR w/ a doc-related label later |
gaozhangmin
reviewed
Jan 18, 2022
...va/org/apache/pulsar/common/naming/SpecifiedTopicCountEquallyDivideBundleSplitAlgorithm.java
Outdated
Show resolved
Hide resolved
|
@aloyszhang:Thanks for providing doc info! |
aloyszhang
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
aloyszhang
force-pushed
the
split
branch
2 times, most recently
from
f127773 to
b8a7619
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
...va/org/apache/pulsar/common/naming/SpecifiedTopicCountEquallyDivideBundleSplitAlgorithm.java
Outdated
Show resolved
Hide resolved
aloyszhang
changed the title
aloyszhang
force-pushed
the
split
branch
2 times, most recently
from
cc0d3be to
87a2af5
Compare
aloyszhang
changed the title
aloyszhang
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@codelipenghui @Jason918 PTAL, thanks |
Jason918
reviewed
Mar 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/common/naming/SpecifiedPositionsBundleSplitAlgorithm.java
Show resolved
Hide resolved
...rc/test/java/org/apache/pulsar/common/naming/SpecifiedPositionsBundleSplitAlgorithmTest.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
codelipenghui
requested changes
Mar 4, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/BundleSplitOption.java
Outdated
Show resolved
Hide resolved
...lient-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TopicHashPositions.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/common/naming/SpecifiedPositionsBundleSplitAlgorithm.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
the
type/feature
aloyszhang
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@codelipenghui PTAL |
codelipenghui
approved these changes
Mar 7, 2022
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
Looks good to me, just left a minor comment, PTAL.
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
* support split bundle by specified boundaries * add license header * fix checkstyle * fix test NPE * fix test * fix checkstyle * fix test * apply comments * remove un-used import * apply comments * apply comments * fix test
4 tasks
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 8, 2022
* support split bundle by specified boundaries * add license header * fix checkstyle * fix test NPE * fix test * fix checkstyle * fix test * apply comments * remove un-used import * apply comments * apply comments * fix test (cherry picked from commit 7998c44)
dlg99
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 8, 2022
* support split bundle by specified boundaries * add license header * fix checkstyle * fix test NPE * fix test * fix checkstyle * fix test * apply comments * remove un-used import * apply comments * apply comments * fix test (cherry picked from commit 7998c44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13761
Motivation
Support split partitions belonging to specified topic in a bundle
Modifications
SpecifiedTopicCountEquallyDivideBundleSplitAlgorithmBundleSplitOptionDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Need to update docs?
no-need-doc