(fix): add conditional for nodePort check#984
Merged
adutra merged 6 commits intoapache:mainfrom Feb 18, 2025
kameshsampath:issue/helm-981
Merged
(fix): add conditional for nodePort check#984adutra merged 6 commits intoapache:mainfrom kameshsampath:issue/helm-981
adutra merged 6 commits intoapache:mainfrom
kameshsampath:issue/helm-981
Conversation
kameshsampath
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Contributor
Author
Contributor
|
Nice! Do you mind also adding a unit test to |
MonkeyCanCode
approved these changes
Feb 12, 2025
adutra
approved these changes
Feb 12, 2025
auto-merge was automatically disabled
February 17, 2025 03:39
Head branch was pushed to by a user without write access
Contributor
Author
Contributor
|
There was a broken CI earlier. Can u do a empty commit to trigger CI again? Then we should be able to get this in. |
Contributor
@kameshsampath seem likes helm test failed. I had add the fix as comment to your PR. |
helm/polaris/tests/service_test.yaml
Outdated
| nodePort: 30081 | ||
| name: polaris-http | ||
| asserts: | ||
| - equal: spec.type |
Contributor
There was a problem hiding this comment.
Change to following:
- equal:
path: spec.type
value: NodePort
Contributor
Author
There was a problem hiding this comment.
not sure I understand your change, the line 168-169 already has that asset
- equal: spec.type
value: NodePort
helm/polaris/tests/service_test.yaml
Outdated
| targetPort: 18181 | ||
| name: polaris-http | ||
| asserts: | ||
| - equal: spec.type |
Contributor
There was a problem hiding this comment.
- equal:
path: spec.type
value: NodePort
adutra
approved these changes
Feb 18, 2025
Contributor
|
Thanks @kameshsampath for the fix and @MonkeyCanCode for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added extra conditional check to #626 to add check to NodePort before adding the port.
fix: #981