Set the correct HTTP Header, Accept not Accepts#93
Merged
collado-mike merged 1 commit intoapache:mainfrom Aug 5, 2024
Merged
Conversation
adutra
approved these changes
Aug 5, 2024
snazy
pushed a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
No functional change. Introduce a dedicated interface for `StsClient` suppliers and implement it using a pool of cached clients. All client are "thin" and share the same `SdkHttpClient`. The latter is closed when the server shuts down. This is a step towards supporting non-AWS S3 storage (apache#1530). For this reason the STS endpoint is present in new interfaces, but is not used yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scripts in
regtestsrunningcurlcommand specifies header as Accepts, whereas the proper header should be Accepthttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept
I don’t believe this will have any functional impact.
Fixes #92
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
docker compose up --build --exit-code-from regtestTest Configuration:
Checklist:
Please delete options that are not relevant.