Update Trino Getting-started example to use default authenticator#877
Merged
flyrain merged 2 commits intoapache:mainfrom Jan 27, 2025
Merged
Update Trino Getting-started example to use default authenticator#877flyrain merged 2 commits intoapache:mainfrom
flyrain merged 2 commits intoapache:mainfrom
Conversation
HonahX
force-pushed
the
honahx_fix_trino_after_804_review
branch
from
c3e190b to
5d7e237
Compare
HonahX
changed the title
HonahX
changed the title
HonahX
commented
Jan 26, 2025
| iceberg.rest-catalog.uri=http://polaris:8181/api/catalog | ||
| iceberg.rest-catalog.security=OAUTH2 | ||
| iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm | ||
| iceberg.rest-catalog.oauth2.credential=root:s3cr3t |
Contributor
Author
There was a problem hiding this comment.
Make it consistent with other examples in #859
HonahX
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
reviewed
Jan 26, 2025
flyrain
approved these changes
Jan 27, 2025
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
adutra
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update in #804, we switched to "default" authenticator in regtest, we can also use the same setup in the trino example. This PR is a follow-up of #868 to use default authenticator in trino example.