Fix Trino Getting-started Example#868
Conversation
| iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm | ||
| iceberg.rest-catalog.warehouse=polaris | ||
| # Required to support local filesystem: https://trino.io/docs/current/object-storage.html#configuration | ||
| fs.hadoop.enabled=true |
There was a problem hiding this comment.
This is related to a breaking change in Trino iceberg connector: link
We have to explicitly enable filesystem support : https://trino.io/docs/current/object-storage.html#configuration
HonahX
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
| ## Build Polaris Image | ||
| Build Polaris Image while Docker is running | ||
| ``` | ||
| ./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true |
There was a problem hiding this comment.
General question (not about this PR specificaly): should not we rename polaris-quarkus-server to polaris-server now ? @adutra thoughts ?
There was a problem hiding this comment.
Not opposed to a global renaming and removing the quarkus token from all module names 👍
| iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm | ||
| iceberg.rest-catalog.warehouse=polaris | ||
| # Required to support local filesystem: https://trino.io/docs/current/object-storage.html#configuration | ||
| fs.hadoop.enabled=true |
| AZURE_CLIENT_SECRET: $AZURE_CLIENT_SECRET | ||
| # add aws keys as dropwizard config | ||
| JAVA_OPTS: -Ddw.awsAccessKey=$AWS_ACCESS_KEY_ID -Ddw.awsSecretKey=$AWS_SECRET_ACCESS_KEY | ||
| polaris.persistence.type: in-memory |
There was a problem hiding this comment.
Sorry I missed that docker-compose file, I should have adapted it to Quarkus earlier. My bad.
|
Thanks @HonahX for the fix. Thanks @adutra @jbonofre and @eric-maynard for the review. |
5 participants
Updates Trino example to make it working again. There are 2 major part of changes
fs.hadoop.enabled=trueto enable Local Filesystem support for Trino