Optionally build Polaris Server Quarkus uber-jar#797
Optionally build Polaris Server Quarkus uber-jar#797snazy wants to merge 1 commit intoapache:mainfrom
Conversation
snazy
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
takidau and
vvcephei
as code owners
snazy
changed the title
We currently build Polaris Quarkus as a `fast-jar`. In order to eventually publish the Polaris Quarkus server in a binary release to Maven Central, it is beneficial to use an uber-jar. This change allows to do that if the project property `uber-jar` is present, for example `./gradlew publishToMavenLocal -Puber-jar` Note that the Quarkus uber-jars are placed directly in the Gradle project's `build/` directory, not in `build/libs/`
|
I'm not opposed to the idea, but isn't this redundant with the Right now, 2 archives are being generated with the following content, including the required license files: 
|
Related, but different. The |
| contents { | ||
| from(project.layout.buildDirectory.dir("quarkus-app")) | ||
| if (quarkusFatJar) { | ||
| from(project.layout.buildDirectory) { include("polaris-quarkus-admin-*-runner.jar") } |
There was a problem hiding this comment.
Why doesn't this go in /libs?
|
There are some pros and cons for each approach. Let's think a bit more about this change - putting it to "draft" for now. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
3 participants
We currently build Polaris Quarkus as a
fast-jar. In order to eventually publish the Polaris Quarkus server in a binary release to Maven Central, it is beneficial to use an uber-jar.This change allows to do that if the project property
uber-jaris present, for example./gradlew publishToMavenLocal -Puber-jarNote that the Quarkus uber-jars are placed directly in the Gradle project's
build/directory, not inbuild/libs/