Build/testing: add java-test-fixtures to every Java project & reduce repeated dependency declarations#714
Merged
snazy merged 1 commit intoapache:mainfrom Jan 14, 2025
Merged
Conversation
snazy
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
takidau and
vvcephei
as code owners
snazy
force-pushed
the
build-test-fixtures
branch
from
46d120b to
9b29ff9
Compare
snazy
changed the title
java-test-fixtures to every Java project & reduc…java-test-fixtures to every Java project & reduce repeated dependency declarations
snazy
force-pushed
the
build-test-fixtures
branch
from
9b29ff9 to
922ad05
Compare
…e repeated dependency declarations Reduce the amount of dependency declarations in all projects by adding adding the dependencies logback-classic (runtimeOnly) and assertj+mockito (implementation) to all test sources. test-fixtures get junit-jupiter+assertj+mockito as implementation dependencies. Also ensures that `useJUnitJupiter` is called with the correct version (it implicitly adds the jupiter runtime). logback-classic is needed at test runtime to actually get logs during test executions, logback-core is a dependency of logback-classic that provides the logback implementation.
snazy
force-pushed
the
build-test-fixtures
branch
from
922ad05 to
0568658
Compare
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Jan 14, 2025
... after apache#714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the amount of dependency declarations in all projects by adding adding the dependencies logback-classic (runtimeOnly) and assertj+mockito (implementation) to all test sources. test-fixtures get junit-jupiter+assertj+mockito as implementation dependencies.
Also ensures that
useJUnitJupiteris called with the correct version (it implicitly adds the jupiter runtime).logback-classic is needed at test runtime to actually get logs during test executions, logback-core is a dependency of logback-classic that provides the logback implementation.