Introduce Polaris Admin Tool (with bootstrap and purge commands)#605
Merged
adutra merged 3 commits intoapache:mainfrom Jan 14, 2025
Merged
Introduce Polaris Admin Tool (with bootstrap and purge commands)#605adutra merged 3 commits intoapache:mainfrom
adutra merged 3 commits intoapache:mainfrom
Conversation
adutra
changed the title
adutra
force-pushed
the
quarkus-commands
branch
13 times, most recently
from
6a50ff4 to
9426e7b
Compare
adutra
force-pushed
the
quarkus-commands
branch
from
9426e7b to
43fb4ea
Compare
adutra
force-pushed
the
quarkus-commands
branch
from
43fb4ea to
31aedd4
Compare
adutra
force-pushed
the
quarkus-commands
branch
10 times, most recently
from
53da2ac to
21fc9dd
Compare
adutra
force-pushed
the
quarkus-commands
branch
from
21fc9dd to
4020a32
Compare
adutra
changed the title
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
force-pushed
the
quarkus-commands
branch
from
4020a32 to
1255c84
Compare
Contributor
Author
|
Note: documentation for the tool will come in #700. |
snazy
reviewed
Jan 14, 2025
|
|
||
| public abstract class BaseCommand implements Callable<Integer> { | ||
|
|
||
| public static final Integer EXIT_CODE_BOOTSTRAP_ERROR = 2; |
Member
There was a problem hiding this comment.
Let's not use 2 (and 1) here - it has a special meaning for some shells ("Misuse of shell built-in...").
Contributor
Author
There was a problem hiding this comment.
Replaced with 3 and 4.
snazy
reviewed
Jan 14, 2025
|
|
||
| @Override | ||
| public String[] getVersion() throws Exception { | ||
| URL resource = |
Member
There was a problem hiding this comment.
You can use PolarisVersion and not do the resource-dance.
snazy
reviewed
Jan 14, 2025
| # under the License. | ||
| # | ||
|
|
||
| polaris.version=${polarisVersion} |
Member
There was a problem hiding this comment.
Don't need this - use PolarisVersion
snazy
reviewed
Jan 14, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Overall LGTM - just replace the version-dance with PolarisVersion.
As a follow up - maybe worth to add some commands to dump the NOTICE/LICENSE/LICENSE-BINARY-DIST files (accessible via PolarisVersion as well).
Member
|
Code looks quite familiar though ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new module,
polaris-quarkus-adminwith maintenance commands such asbootstrapandpurge.For the
bootstrapcommand, this PR creates a way for the command to pass an instance ofPolarisBootstrapCredentialsto the meta store, thus avoiding the need for environment variables completely.