Implement missing doc "Configuring Polaris for Production"#43
Conversation
…oduction Ensure new links are rendered in web
|
I think #47 needs to be merged to use eclipse link. |
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Left some nits, but looks like a great addition to the docs.
|
It's possible to also change the following code to allow config-file from outside the classpath in this PR? At private Map<String, String> loadProperties(String confFile, String persistenceUnitName) {
if (this.properties != null) {
return this.properties;
}
try {
- InputStream input = this.getClass().getClassLoader().getResourceAsStream(confFile);
+ FileInputStream input = new FileInputStream(confFile);
}
} |
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Good to go, I think we can clean up my remaining comments in a future PR if needed. The docs will be going through a lot of evolution and I think it's important we get this info out ASAP
This change won't work. This change will allow you to load an external config file but it will fail later on. See details in #79. @sfc-gh-aixu purposed a fix in #88. |
…k when doing lookupEntity (apache#43)
7 participants
Description
This PR implements the missing doc
docs/configuring-polaris-for-production.mdreferred to in other docs.Type of change
This is a doc-only change
How Has This Been Tested?
This is a doc-only change
Checklist: