Enable defining custom test environments#391
Merged
eric-maynard merged 3 commits intoapache:mainfrom Nov 4, 2024
Merged
Conversation
andrew4699
requested review from
RussellSpitzer,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
polaris-service/src/test/java/org/apache/polaris/service/test/TestEnvironment.java
Outdated
Show resolved
Hide resolved
| * clients. This should be a class name. If this is not set, falls back to the client created by | ||
| * Dropwizard. | ||
| */ | ||
| public static final String ENV_HTTP_CLIENT_FACTORY_IMPL = |
Contributor
There was a problem hiding this comment.
This approach seems a bit roundabout. Is there a way we can achieve this with a service file?
Contributor
Author
There was a problem hiding this comment.
For things like this the project seems to have relied on providing a test config file and Jackson parsing the config. I'm hoping to decouple this from Dropwizard and for non-Dropwizard environments also not force people to go through that whole dance.
polaris-service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java
Outdated
Show resolved
Hide resolved
polaris-service/src/test/java/org/apache/polaris/service/test/TestEnvironmentExtension.java
Outdated
Show resolved
Hide resolved
eric-maynard
requested changes
Oct 22, 2024
Contributor
eric-maynard
left a comment
eric-maynard
left a comment
There was a problem hiding this comment.
Left a few questions
collado-mike
approved these changes
Oct 23, 2024
polaris-service/src/test/java/org/apache/polaris/service/test/TestEnvironment.java
Outdated
Show resolved
Hide resolved
andrew4699
force-pushed
the
aguterman-dynamic-test-environment
branch
2 times, most recently
from
3bac154 to
0afb1a3
Compare
andrew4699
force-pushed
the
aguterman-dynamic-test-environment
branch
2 times, most recently
from
458320e to
c81e4a3
Compare
eric-maynard
approved these changes
Nov 1, 2024
andrew4699
force-pushed
the
aguterman-dynamic-test-environment
branch
from
76bc3f5 to
1229ab9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a test-only change which adds a pattern for running tests against user-specified environments by specifying your own base URL and HTTP client. Makes PolarisRestCatalogViewIntegrationTest use the custom test environment. In a future PR I plan to do similar for other tests but I'd like this PR to just start the pattern.
Example:
Type of change
How Has This Been Tested?
Checklist: