Conversation
|
Depends on #3614 due to the deprecation-changes (Quarkus 3.30 has JUnit 5, 3.31 has JUnit 6) |
| ExtensionContext classCtx = classContext(context); | ||
| ExtensionContext.Store store = classCtx.getStore(NAMESPACE); | ||
| return store.getOrComputeIfAbsent( | ||
| return store.computeIfAbsent( |
There was a problem hiding this comment.
Will this require downstream projects that want to reuse this extension to also upgrade to JUnit 6?
There was a problem hiding this comment.
Downstream projects implicitly use JUnit 6 with Quarkus 3.31.
There was a problem hiding this comment.
However, the integration-tests module is not hard-wired to Quarkus... It is usable in a standalone manner 🤔
There was a problem hiding this comment.
The only implementation uses Quarkus though.
There was a problem hiding this comment.
This change is not required for Polaris to use JUnit 6. It is merely a deprecation warning fix in Polaris, but it forces downstream projects for switch to JUnit 6.
Prior work (e.g. #391) makes me think that such use cases might exist outside the Quarkus build env. (and thus may not inherit JUnit 6).
Whether this is still a relevant use case or not I cannot tell, but it might be worth keeping JUnit 5 compatibility for some more time.
...a/org/apache/polaris/persistence/relational/jdbc/idempotency/PostgresIdempotencyStoreIT.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Since apache#3712 has been merged, we can bump JUnit to version 6. This change also tackes a few deprecation warnings.
|
I've removed all deprecation changes from this PR. |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Thx! 👍 |
3 participants
Since #3712 has been merged, we can bump JUnit to version 6.