Skip to content

Correct build instruction, project properties require org.gradle.project prefix#3680

Merged
dimas-b merged 2 commits intoapache:mainfrom
nandorKollar:fix_doc_metastore_federation
Feb 6, 2026
Merged

Correct build instruction, project properties require org.gradle.project prefix#3680
dimas-b merged 2 commits intoapache:mainfrom
nandorKollar:fix_doc_metastore_federation

Conversation

@nandorKollar
Copy link
Contributor

@nandorKollar nandorKollar commented Feb 5, 2026

This is a minor doc fix for the build command in the federated metastore instructions: it appears project properties neer the 'org.gradle.project' prefix to work correctly.

Checklist

  • 🛡️ Don't disclose security issues! (contact [email protected])
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

jbonofre
jbonofre previously approved these changes Feb 5, 2026
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Feb 5, 2026
@jbonofre
Copy link
Member

jbonofre commented Feb 5, 2026

Good catch.

@jbonofre
Copy link
Member

jbonofre commented Feb 5, 2026

Thanks !

The other option is to pass it as an argument to the gradle JVM as follows:
```
./gradlew build -DNonRESTCatalogs=HIVE
./gradlew build -Dorg.gradle.project.NonRESTCatalogs=HIVE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new -D works too, but -P seems to be clearer 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, -P also works. Let me replace it to -P.

Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nandorKollar !

I assume @jbonofre 's previous approval holds for -P too 🙂 so I'm merging.

@dimas-b dimas-b merged commit 103c6ed into apache:main Feb 6, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Feb 6, 2026
sungwy pushed a commit to sungwy/polaris that referenced this pull request Feb 7, 2026
…ect prefix (apache#3680)

* Correct build instruction, project properties require org.gradle.project prefix

---------

Co-authored-by: Nandor Kollar <[email protected]>
snazy added a commit to snazy/polaris that referenced this pull request Feb 11, 2026
* Simplify CatalogPrefixParser API (apache#3622)

This component's methods do not need to have a `RealmContext` parameter: either the implementation is application-scoped, in which case the realm is irrelevant; or the implementation is request-scoped, in which case it can have the `RealmContext` injected. (FWIW, the default implementation is application-scoped.)

This refactor will further simplify the remote request signing implementation.

* Releasey: update check for required-checks (apache#3667)

After apache#3625 the `jq` select to look for required checks can be simplified to select only the `Required Checks` check/job.

* Wire external catalog properties into REST client config (apache#3480)

* pass ExternalCatalog.properties through federation factories (Iceberg REST, Hive, Hadoop)

* merge catalog properties with connection config, with connection config taking precedence

* document proxy/timeout settings for Iceberg REST federation

* add tests that exercise production merge logic

* Correct build instruction, project properties require org.gradle.project prefix (apache#3680)

* Correct build instruction, project properties require org.gradle.project prefix

---------

Co-authored-by: Nandor Kollar <[email protected]>

* Last merged commit 103c6ed

---------

Co-authored-by: Alexandre Dutra <[email protected]>
Co-authored-by: Yong-Jin Lee <[email protected]>
Co-authored-by: Nándor Kollár <[email protected]>
Co-authored-by: Nandor Kollar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants