Merged
Conversation
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
singhpk234
approved these changes
Feb 1, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
This refactor seems reasonable to me, considering we have a path forward with injecting the realm-context in the impl.
i also would request @collado-mike @dennishuo also to take a look into this from the down stream service integration pov.
This component's methods do not need to have a `RealmContext` parameter: either the implementation is application-scoped, in which case the realm is irrelevant; or the implementation is request-scoped, in which case it can have the `RealmContext` injected. (FWIW, the default implementation is application-scoped.) This refactor will further simplify the remote request signing implementation.
adutra
force-pushed
the
prefix-parser-refactor
branch
from
6c2874b to
5c45d56
Compare
Contributor
Author
|
@collado-mike @dennishuo any concerns? If not I propose to merge this on Feb. 5th. |
collado-mike
approved these changes
Feb 5, 2026
Contributor
collado-mike
left a comment
collado-mike
left a comment
There was a problem hiding this comment.
I think this seems benign enough
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Contributor
Author
|
Thank you all for the reviews! |
sungwy
pushed a commit
to sungwy/polaris
that referenced
this pull request
Feb 7, 2026
This component's methods do not need to have a `RealmContext` parameter: either the implementation is application-scoped, in which case the realm is irrelevant; or the implementation is request-scoped, in which case it can have the `RealmContext` injected. (FWIW, the default implementation is application-scoped.) This refactor will further simplify the remote request signing implementation.
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Feb 11, 2026
* Simplify CatalogPrefixParser API (apache#3622) This component's methods do not need to have a `RealmContext` parameter: either the implementation is application-scoped, in which case the realm is irrelevant; or the implementation is request-scoped, in which case it can have the `RealmContext` injected. (FWIW, the default implementation is application-scoped.) This refactor will further simplify the remote request signing implementation. * Releasey: update check for required-checks (apache#3667) After apache#3625 the `jq` select to look for required checks can be simplified to select only the `Required Checks` check/job. * Wire external catalog properties into REST client config (apache#3480) * pass ExternalCatalog.properties through federation factories (Iceberg REST, Hive, Hadoop) * merge catalog properties with connection config, with connection config taking precedence * document proxy/timeout settings for Iceberg REST federation * add tests that exercise production merge logic * Correct build instruction, project properties require org.gradle.project prefix (apache#3680) * Correct build instruction, project properties require org.gradle.project prefix --------- Co-authored-by: Nandor Kollar <[email protected]> * Last merged commit 103c6ed --------- Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Yong-Jin Lee <[email protected]> Co-authored-by: Nándor Kollár <[email protected]> Co-authored-by: Nandor Kollar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component's methods do not need to have a
RealmContextparameter: either the implementation is application-scoped, in which case the realm is irrelevant; or the implementation is request-scoped, in which case it can have theRealmContextinjected. (FWIW, the default implementation is application-scoped.)This refactor will further simplify the remote request signing implementation.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)