Skip to content

Guides: compose dependencies / long-option#3611

Merged
snazy merged 1 commit intoapache:mainfrom
snazy:guides-depends-longopt
Jan 31, 2026
Merged

Guides: compose dependencies / long-option#3611
snazy merged 1 commit intoapache:mainfrom
snazy:guides-depends-longopt

Conversation

@snazy
Copy link
Member

@snazy snazy commented Jan 29, 2026

Docker compose's "short" depends_on syntax (just mentioning the dependent service) does not assert on the expected condition (service_healthy or service_completed_successfully). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.

Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.
@snazy snazy force-pushed the guides-depends-longopt branch from e49fa5a to 79b13e1 Compare January 29, 2026 14:16
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 29, 2026
polaris:
condition: service_healthy
polaris-setup:
condition: service_completed_successfully
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are changing to tail forever on the other PR, we will need to change this to service_healthy instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
I'll adjust the other PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's not strictly needed in the other PR for the telemetry guide, but I've added it for consistency across the guides.

@snazy snazy merged commit 60bfea8 into apache:main Jan 31, 2026
15 checks passed
@snazy snazy deleted the guides-depends-longopt branch January 31, 2026 09:45
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jan 31, 2026
sungwy pushed a commit to sungwy/polaris that referenced this pull request Feb 7, 2026
Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.
snazy added a commit to snazy/polaris that referenced this pull request Feb 11, 2026
* Fix PolarisEventListener javadoc (apache#3607)

* Adjust javadoc to reference available methods.

* Guides: add mandatory `curl` `--fail` option (apache#3610)

`curl` does _not_ return an error code when the URL can be retrieved but returns an error HTTP status code, for example 404, 403, 401. This means that the health checks are yieldíng "OK" too early.

This change adds the missing `--fail` option.

* Guides: compose dependencies / long-option (apache#3611)

Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.

* fix(deps): update dependency com.google.cloud:google-cloud-iamcredentials to v2.83.0 (apache#3635)

* chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.24-2.1769595317 (apache#3631)

* fix(deps): update dependency com.puppycrawl.tools:checkstyle to v13.1.0 (apache#3637)

* chore(deps): update amazon/aws-cli docker tag to v2.33.12 (apache#3638)

* fix(deps): update dependency com.azure:azure-sdk-bom to v1.3.4 (apache#3633)

* fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.27 (apache#3632)

* chore(deps): update docker.io/openpolicyagent/opa docker tag to v1.13.1 (apache#3634)

* CI: Fix site workflow concurrency (apache#3642)

* Last merged commit 384be9e

---------

Co-authored-by: Dmitri Bourlatchkov <[email protected]>
Co-authored-by: Mend Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants