Merged
Conversation
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
commented
Oct 7, 2024
| keywords: | ||
| - polaris | ||
| - iceberg | ||
| maintainers: |
Contributor
Author
There was a problem hiding this comment.
This list is the result of git shortlog -n -s -- helm. It must contain valid GitHub handles.
snazy
reviewed
Oct 11, 2024
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Overall LGTM - but add it as a required check?
Contributor
|
Looks like all OSS PRs are blocked by the helm tests reporting as the following screenshot shows. Any ideas?
|
Contributor
Author
Contributor
|
Cannot merge it from github due to the same blocker. We need a way to force push it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some basic CI testing for the Polaris Helm chart.
Type of change
CI Tests.
How Has This Been Tested?
CI.
Checklist: