Fix renovate syntax by MonkeyCanCode · Pull Request #3471 · apache/polaris

MonkeyCanCode · 2026-01-18T01:23:45Z

This PR fixed the following:

Remove custom docker regex path in renovate config as that is not necessary and not valid in newer version of renovate
Update our renovate config to use the non-deprecated configs to avoid config rewrite (existed one is still valid)
Added explanation on why certain dockerfiles are not being monitored by renovate bot

Earlier I created #3454 to ensure we have proper regex included for docker. After some testings, I noticed that is actually not necessary and with latest renovate (I was using an older version), those will trigger error as well during configuration validate.

Here is the current valication:

➜  polaris git:(main) docker run --rm \
  -v "$PWD:/work" \
  renovate/renovate:latest \
  renovate-config-validator /work/.github/renovate.json5

 INFO: Validating /work/.github/renovate.json5
 WARN: Config migration necessary
       "oldConfig": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "extends": [
           "config:base",
           ":preserveSemverRanges",
           "group:monorepos",
           "helpers:pinGitHubActionDigests",
           ":semanticPrefixFixDepsChoreOthers",
           ":dependencyDashboard"
         ],
         "baseBranches": ["main"],
         "pip_requirements": {"fileMatch": ["(^|/)([\\w-]*)requirements.*\\.txt$"]},
         "docker": {
           "fileMatch": [
             "(^|/)Dockerfile$",
             "(^|/)Dockerfile\\.[^/]*$",
             "(^|/)Dockerfile-[^/]*$"
           ]
         },
         "packageRules": [
           {
             "matchManagers": [
               "gradle",
               "gradle-wrapper",
               "pip_requirements",
               "pip_setup",
               "uv",
               "setup-cfg",
               "dockerfile",
               "devcontainer",
               "docker-compose",
               "github-actions"
             ],
             "automerge": false
           },
           {
             "matchManagers": ["gradle"],
             "matchPackagePrefixes": ["software.amazon.awssdk"],
             "extends": ["schedule:weekly"]
           },
           {
             "matchManagers": ["pip_requirements", "pip_setup", "uv"],
             "matchPackagePrefixes": ["boto3"],
             "extends": ["schedule:weekly"]
           },
           {
             "groupName": "Quarkus Platform and Group",
             "matchManagers": ["gradle"],
             "matchPackageNames": [
               "io.quarkus.platform:quarkus-bom",
               "io.quarkus.platform:quarkus-amazon-services-bom",
               "io.quarkus.platform:quarkus-google-cloud-services-bom",
               "io.quarkus:io.quarkus.gradle.plugin"
             ]
           },
           {"matchPackageNames": ["openapi-generator-cli"], "enabled": false}
         ],
         "prConcurrentLimit": 50,
         "prHourlyLimit": 5,
         "labels": ["renovate-polaris"]
       },
       "newConfig": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "extends": [
           "config:recommended",
           ":preserveSemverRanges",
           "group:monorepos",
           "helpers:pinGitHubActionDigests",
           ":semanticPrefixFixDepsChoreOthers",
           ":dependencyDashboard"
         ],
         "baseBranchPatterns": ["main"],
         "pip_requirements": {
           "managerFilePatterns": ["/(^|/)([\\w-]*)requirements.*\\.txt$/"]
         },
         "packageRules": [
           {
             "matchCategories": ["docker"],
             "managerFilePatterns": [
               "/(^|/)Dockerfile$/",
               "/(^|/)Dockerfile\\.[^/]*$/",
               "/(^|/)Dockerfile-[^/]*$/"
             ]
           },
           {
             "matchManagers": [
               "gradle",
               "gradle-wrapper",
               "pip_requirements",
               "pip_setup",
               "uv",
               "setup-cfg",
               "dockerfile",
               "devcontainer",
               "docker-compose",
               "github-actions"
             ],
             "automerge": false
           },
           {
             "matchManagers": ["gradle"],
             "extends": ["schedule:weekly"],
             "matchPackageNames": ["software.amazon.awssdk{/,}**"]
           },
           {
             "matchManagers": ["pip_requirements", "pip_setup", "uv"],
             "extends": ["schedule:weekly"],
             "matchPackageNames": ["boto3{/,}**"]
           },
           {
             "groupName": "Quarkus Platform and Group",
             "matchManagers": ["gradle"],
             "matchPackageNames": [
               "io.quarkus.platform:quarkus-bom",
               "io.quarkus.platform:quarkus-amazon-services-bom",
               "io.quarkus.platform:quarkus-google-cloud-services-bom",
               "io.quarkus:io.quarkus.gradle.plugin"
             ]
           },
           {"matchPackageNames": ["openapi-generator-cli"], "enabled": false}
         ],
         "prConcurrentLimit": 50,
         "prHourlyLimit": 5,
         "labels": ["renovate-polaris"]
       }
 WARN: Found errors in configuration
       "file": "/work/.github/renovate.json5",
       "warnings": [
         {
           "topic": "packageRules[0].managerFilePatterns",
           "message": "\"managerFilePatterns\" can't be used in \"packageRules\". Allowed objects: ansible, ansible-galaxy, argocd, asdf, azure-pipelines, batect, batect-wrapper, bazel, bazel-module, bazelisk, bicep, bitbucket-pipelines, bitrise, buildkite, buildpacks, bun, bun-version, bundler, cake, cargo, cdnurl, circleci, cloudbuild, cocoapods, composer, conan, copier, cpanfile, crossplane, crow, customManagers, deps-edn, devbox, devcontainer, docker-compose, dockerfile, droneci, fleet, flux, fvm, git-submodules, github-actions, gitlabci, gitlabci-include, glasskube, gleam, gomod, gradle, gradle-wrapper, haskell-cabal, helm-requirements, helm-values, helmfile, helmsman, helmv3, hermit, homebrew, html, jenkins, jsonnet-bundler, kotlin-script, kubernetes, kustomize, leiningen, maven, maven-wrapper, meteor, mint, mise, mix, nix, nodenv, npm, nuget, nvm, ocb, osgi, pep621, pep723, pip-compile, pip_requirements, pip_setup, pipenv, pixi, poetry, pre-commit, pub, puppet, pyenv, quadlet, renovate-config-presets, ruby-version, runtime-version, sbt, scalafmt, setup-cfg, sveltos, swift, tekton, terraform, terraform-version, terragrunt, terragrunt-version, tflint-plugin, travis, typst, unity3d, velaci, vendir, woodpecker."
         }
       ]

The error is actually from the docker section which is no longer valid for newer version of renovate.

Here is the output for the fixed with this PR:

➜  polaris git:(fix_renovate) docker run --rm \
  -v "$PWD:/work" \
  renovate/renovate:latest \
  renovate-config-validator /work/.github/renovate.json5

 INFO: Validating /work/.github/renovate.json5
 INFO: Config validated successfully

Now back to the original problem where we have couple dockerfiles which are not getting updated. Those are actually done by renovate itself. Here is what I found:

the default regex used by renovate for docker is following (ref: https://docs.renovatebot.com/modules/manager/dockerfile/):

{
  "managerFilePatterns": [
    "/(^|/|\\.)([Dd]ocker|[Cc]ontainer)file$/",
    "/(^|/)([Dd]ocker|[Cc]ontainer)file[^/]*$/"
  ]
}

with above, it should cover the ones we we have as it include dockerfile*|Dockerfile*|containerfile*|Containerfile*. However, this doesn't check certain ones due to config:base (now config:recommended) which has certain dirs excluded (ref: https://docs.renovatebot.com/presets-default/#ignoremodulesandtests). In our case, it excluded all of the dockerfile under paths */test/*|:

monitored:
./plugins/spark/v3.5/regtests/Dockerfile
./plugins/spark/v3.5/getting-started/notebooks/Dockerfile
./runtime/admin/src/testFixtures/resources/org/apache/polaris/admintool/Dockerfile-postgres-version
./runtime/admin/src/main/docker/Dockerfile.jvm
./runtime/server/src/main/docker/Dockerfile.jvm
./regtests/Dockerfile
./getting-started/spark/notebooks/Dockerfile
./persistence/nosql/persistence/db/mongodb/src/testFixtures/resources/org/apache/polaris/persistence/nosql/mongodb/Dockerfile-mongodb-version
./site/docker/Dockerfile

not monitored:
./tools/minio-testcontainer/src/main/resources/org/apache/polaris/test/minio/Dockerfile-minio-version
./runtime/test-common/src/main/resources/org/apache/polaris/test/commons/s3mock/Dockerfile-s3mock-version
./runtime/test-common/src/main/resources/org/apache/polaris/test/commons/Dockerfile-postgres-version
./runtime/test-common/src/main/resources/org/apache/polaris/test/commons/keycloak/Dockerfile-keycloak-version
./runtime/service/src/test/resources/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/Dockerfile-localstack-version
./extensions/auth/opa/tests/src/intTest/resources/org/apache/polaris/extension/auth/opa/test/Dockerfile-opa-version

That being said, to be able to have renovate run on all dockerfiles, we will need to update ignorePaths for dockerfile. Here is the fixed output:

DEBUG: Matched 15 file(s) for manager dockerfile: extensions/auth/opa/tests/src/intTest/resources/org/apache/polaris/extension/auth/opa/test/Dockerfile-opa-version, getting-started/spark/notebooks/Dockerfile, persistence/nosql/persistence/db/mongodb/src/testFixtures/resources/org/apache/polaris/persistence/nosql/mongodb/Dockerfile-mongodb-version, plugins/spark/v3.5/getting-started/notebooks/Dockerfile, plugins/spark/v3.5/regtests/Dockerfile, regtests/Dockerfile, runtime/admin/src/main/docker/Dockerfile.jvm, runtime/admin/src/testFixtures/resources/org/apache/polaris/admintool/Dockerfile-postgres-version, runtime/server/src/main/docker/Dockerfile.jvm, runtime/service/src/test/resources/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/Dockerfile-localstack-version, runtime/test-common/src/main/resources/org/apache/polaris/test/commons/Dockerfile-postgres-version, runtime/test-common/src/main/resources/org/apache/polaris/test/commons/keycloak/Dockerfile-keycloak-version, runtime/test-common/src/main/resources/org/apache/polaris/test/commons/s3mock/Dockerfile-s3mock-version, site/docker/Dockerfile, tools/minio-testcontainer/src/main/resources/org/apache/polaris/test/minio/Dockerfile-minio-version (repository=local)

Here is earlier:

DEBUG: Matched 9 file(s) for manager dockerfile: getting-started/spark/notebooks/Dockerfile, persistence/nosql/persistence/db/mongodb/src/testFixtures/resources/org/apache/polaris/persistence/nosql/mongodb/Dockerfile-mongodb-version, plugins/spark/v3.5/getting-started/notebooks/Dockerfile, plugins/spark/v3.5/regtests/Dockerfile, regtests/Dockerfile, runtime/admin/src/main/docker/Dockerfile.jvm, runtime/admin/src/testFixtures/resources/org/apache/polaris/admintool/Dockerfile-postgres-version, runtime/server/src/main/docker/Dockerfile.jvm, site/docker/Dockerfile (repository=local)

Checklist

🛡️ Don't disclose security issues! (contact [email protected])
🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
🧪 Added/updated tests with good coverage, or manually tested (and explained how)
💡 Added comments for complex logic
🧾 Updated CHANGELOG.md (if needed)
📚 Updated documentation in site/content/in-dev/unreleased (if needed)

snazy

Thanks @MonkeyCanCode for this PR and especially for the exhaustive PR description!
+1

jbonofre · 2026-01-19T13:32:34Z

@MonkeyCanCode good catch ! Thanks !

* Use injected RealmConfig in JdbcMetaStoreManagerFactory (apache#3412) * Use injected RealmConfig in JdbcMetaStoreManagerFactory * Improve code isolation by using `RealmConfig` (like most other code) instead of the lower-level `PolarisConfigurationStore` * This also enabled proper CDI request-scoped injection in concert with apache#3411 * Additionally, this enables further code cleanup in `PolarisConfigurationStore` as discussed in apache#3324 with the goal of using this interface for the backend configuration code, while `RealmConfig` becomes the corresponding frontend interface. * Fix `ServiceProducers.realmConfig()` to make a `RealmConfigImpl` directly from its dependencies (not from `CallContext`) to avoid cycles in CDI. * Fix renovate syntax (apache#3471) * Remove client_id, client_secret regex/pattern validation on reset endpoint call (apache#3276) client_id/client_secret patterns are validated when calling reset endpoint but the pattern is hardcoded which can be too rigid. * Use typed config for `TABLE_METADATA_CLEANUP_BATCH_SIZE` (apache#3478) Add a typed `FeatureConfiguration` with the same config name and default value. * chore(deps): update docker.io/adobe/s3mock docker tag to v4.11.0 (apache#3492) * fix(deps): update dependency io.smallrye.config:smallrye-config-core to v3.15.1 (apache#3490) * fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.25 (apache#3489) * chore(deps): update plugin com.gradle.develocity to v4.3.1 (apache#3452) * Last merged commit 738bce9 --------- Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Romain Manni-Bucau <[email protected]> Co-authored-by: Mend Renovate <[email protected]>

MonkeyCanCode added 2 commits January 17, 2026 18:50

Fix renovate

057b6d8

Fix renovate

c60e6b4

github-project-automation bot added this to Basic Kanban Board Jan 18, 2026

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jan 18, 2026

MonkeyCanCode requested review from dimas-b, flyrain and snazy January 18, 2026 01:23

snazy approved these changes Jan 19, 2026

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 19, 2026

jbonofre approved these changes Jan 19, 2026

View reviewed changes

dimas-b approved these changes Jan 19, 2026

View reviewed changes

MonkeyCanCode merged commit 5e5779f into apache:main Jan 19, 2026
15 checks passed

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jan 19, 2026

evindj pushed a commit to evindj/polaris that referenced this pull request Jan 26, 2026

Fix renovate syntax (apache#3471)

12010b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix renovate syntax#3471

Fix renovate syntax#3471
MonkeyCanCode merged 2 commits intoapache:mainfrom
MonkeyCanCode:fix_renovate

MonkeyCanCode commented Jan 18, 2026

Uh oh!

snazy left a comment

Uh oh!

jbonofre commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MonkeyCanCode commented Jan 18, 2026

Checklist

Uh oh!

snazy left a comment

Choose a reason for hiding this comment

Uh oh!

jbonofre commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants