PRs: Remove markdown-links-check from required checks by snazy · Pull Request #3102 · apache/polaris

snazy · 2025-11-20T11:00:24Z

The "Check Markdown links" workflow is known to produce false failures, leading to #3097.

This change is intended to unblock PRs due to these false failures.

The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097. This change is intended to unblock PRs due to these false failures.

dimas-b · 2025-11-20T14:35:55Z

+1

Markdown checks are very flaky and have been hindering PRs progress.

Recent example: https://github.com/apache/polaris/actions/runs/19534001072/job/55941993028?pr=2802

ERROR: 1 dead links found!
[✖] https://medium.com/@jitenderkmr/demystifying-snowflake-ids-a-unique-identifier-in-distributed-computing-72796a827c9d → Status: 403

^ that link works fine in a browser.

The step was disabled in apache#3102 to pass CI and enable merging.

binarycat0 · 2025-11-20T14:44:49Z

Will it help if extend set of ignorePatterns in .github/workflows/check-md-link-config.json?

{
  "ignorePatterns": [
    {
      "pattern": "https://medium.com/.*"
    },
    {
      "pattern": "^https?://localhost.*"
    },
    {
      "_comment": "mvnrepository blocks requests originating from GitHub Actions",
      "pattern": "https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark"
    }
  ]
}

snazy · 2025-11-20T14:46:14Z

Will it help if extend set of ignorePatterns in .github/workflows/check-md-link-config.json?

{
  "ignorePatterns": [
    {
      "pattern": "https://medium.com/.*"
    },
    {
      "pattern": "^https?://localhost.*"
    },
    {
      "_comment": "mvnrepository blocks requests originating from GitHub Actions",
      "pattern": "https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark"
    }
  ]
}

Maybe? ;)
Mind propsing on the dev-ML as a follow-up?

binarycat-dremio

LGTM

pingtimeout

Approving to unblock CI

A better long-term solution might be to replace the trigger by a manual trigger (like the release workflows). That way we would still be able to check for dead links but we would not use our request quota unless we want it.

The step was disabled in apache#3102 to pass CI and enable merging.

The step was disabled in #3102 to pass CI and enable merging.

* Docs: update Helm Chart page to show usage without cloning Polaris github repo (apache#2939) * Docs: update Helm Chart page to show usage without cloning Polaris github repo * Apply suggestions from code review * Add separate flows in Helm Chart doc for installing released chart and images vs building from source --------- Co-authored-by: Alexandre Dutra <[email protected]> * docs: improve getting started and README documentation (apache#2267) * The outdated config snippets and health-checks are removed from the index * The binary guide stays focused and concise * Update changelog with missing 1.3.0 features (apache#3087) * Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.23-6.1763034977 (apache#3092) * Update docker.io/jaegertracing/all-in-one Docker tag to v1.75.0 (apache#3093) * feat: Make generate_clients.py windows compatible (apache#3084) * Make generate_clients.py windows compatible * Updated CHANGELOG.md * PRs: Remove markdown-links-check from required checks (apache#3102) The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097. This change is intended to unblock PRs due to these false failures. * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0 (apache#3083) * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0 * spotlessApply --------- Co-authored-by: Robert Stupp <[email protected]> * chore(deps): update gradle to v9.2.1 (apache#3069) * chore(deps): update gradle to v9.2.1 * Fix Grale wrapper SHA --------- Co-authored-by: Robert Stupp <[email protected]> * chore(deps): update mongo docker tag to v8.2.2 (apache#3100) * chore(deps): update docker.io/mongo docker tag to v8.2.2 (apache#3099) * Source-tarball - eliminate git-gzip risk (apache#3075) Details in the `git archive` chapter in https://reproducible-builds.org/docs/archives/ * NoSQL: Allow `null` IndexKey (de)serialization (apache#3076) This change adopts the implementation to the API specification. * PRs: Re-add markdown-links-check step (apache#3103) The step was disabled in apache#3102 to pass CI and enable merging. * NoSQL: Add maintenance implementation (apache#3077) * Inject DefaultFileIOFactory in tests (apache#3043) * Inject DefaultFileIOFactory in tests also simplify `TaskFileIOSupplier` usage in tests, which allows removal of `TestFileIOFactory`. * Update Quarkus Platform and Group to v3.29.4 (apache#3094) * Site: Replace feather logo (apache#3101) The ASF has a new logo, a leaf. There is sadly no free icon that matches the new logo, so replacing the feather-ASF with "The ASF" in the top-bar navigation. * Update actions/checkout action to v6 (apache#3106) * Core: resolveAll() must be called before reading resolution results (apache#3064) * Site: Added GCS related Bucket Properties for vending credentials. (apache#3066) * Publish/pom: don't include test-fixtures dependencies as runtime (apache#3085) The list of dependencies in pom's includes the api/runtime elements of the test-fixtures, which is not what should be published, as it "pulls up" deps like junit, mockito and assertj as Maven runtime scope dependencies. This change fixes this. * Increase javadoc visibility in `persistence/nosql/persistence/cdi/weld` (apache#3110) This is to fix javadoc error: `No public or protected classes found to document` * Disable cloud storage tests that would use @tempdir (apache#3095) Disable tests from ViewCatalogTests for cloud storage integration tests (S3, ADLS, GCS) that would otherwise use @tempdir. Since @tempdir internally uses Paths.get, it cannot point to cloud storage paths. These tests remain enabled for file-based integration tests. * Remove 'beta' label for Generic Table (apache#3096) * remove beta label * address comments for change log --------- Co-authored-by: Pierre Laporte <[email protected]> * Update dependency jupyterlab to v4.5.0 (apache#3074) * chore: Fix md link check in GH action (apache#3128) * Fix md link check in GH action * Fix md link check in GH action * Update dependency pre-commit to v4.5.0 (apache#3123) * Update dependency software.amazon.awssdk:bom to v2.39.2 (apache#3127) * NoSQL: authZ API, SPI, impl and store (apache#3078) NoSQL base functionality for ACLs * NoSQL: Quarkus distributed cache invalidation (apache#3105) Adds support for distributed NoSQL cache invalidation leveraging Quarkus. * NoSQL: adjustments / merge fixes * Last merged commit e124348 --------- Co-authored-by: Oleg Soloviov <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Subham <[email protected]> Co-authored-by: Pierre Laporte <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: Saksham Ratra <[email protected]> Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Tamas Mate <[email protected]> Co-authored-by: Yun Zou <[email protected]>

PRs: Remove markdown-links-check from required checks

3dfb88b

The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097. This change is intended to unblock PRs due to these false failures.

github-project-automation bot added this to Basic Kanban Board Nov 20, 2025

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 20, 2025

snazy mentioned this pull request Nov 20, 2025

Handle markdown-link-check flaky failures #3097

Closed

dimas-b previously approved these changes Nov 20, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 20, 2025

temp remove check

e8c4205

snazy dismissed dimas-b’s stale review via e8c4205 November 20, 2025 14:37

snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025

PRs: Re-add markdown-links-check step

4d2682e

The step was disabled in apache#3102 to pass CI and enable merging.

dimas-b approved these changes Nov 20, 2025

View reviewed changes

snazy mentioned this pull request Nov 20, 2025

PRs: Re-add markdown-links-check step #3103

Merged

dimas-b mentioned this pull request Nov 20, 2025

adding support to use a kms key for s3 buckets data encryption (AWS only) #2802

Merged

binarycat-dremio approved these changes Nov 20, 2025

View reviewed changes

pingtimeout approved these changes Nov 20, 2025

View reviewed changes

snazy merged commit c9d27dc into apache:main Nov 20, 2025
15 checks passed

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 20, 2025

snazy deleted the md-link-check-optional branch November 20, 2025 14:50

snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025

PRs: Re-add markdown-links-check step

19630ef

The step was disabled in apache#3102 to pass CI and enable merging.

snazy added a commit that referenced this pull request Nov 20, 2025

PRs: Re-add markdown-links-check step (#3103)

132146d

The step was disabled in #3102 to pass CI and enable merging.

dimas-b mentioned this pull request Nov 21, 2025

Do not fail a release when markdown-link-check check fails as it is flaky #3116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PRs: Remove markdown-links-check from required checks#3102

PRs: Remove markdown-links-check from required checks#3102
snazy merged 2 commits intoapache:mainfrom
snazy:md-link-check-optional

snazy commented Nov 20, 2025

Uh oh!

dimas-b commented Nov 20, 2025 •

edited

Loading

Uh oh!

binarycat0 commented Nov 20, 2025

Uh oh!

snazy commented Nov 20, 2025

Uh oh!

binarycat-dremio left a comment

Uh oh!

pingtimeout left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

snazy commented Nov 20, 2025

Uh oh!

dimas-b commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

binarycat0 commented Nov 20, 2025

Uh oh!

snazy commented Nov 20, 2025

Uh oh!

binarycat-dremio left a comment

Choose a reason for hiding this comment

Uh oh!

pingtimeout left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dimas-b commented Nov 20, 2025 •

edited

Loading