chore(enhancement): rename python package to apache-polaris#2812
Conversation
0d34b23 to
395cb27
Compare
4e6bbc6 to
e797543
Compare
|
@MonkeyCanCode @HonahX Hello colleagues. Please review. Thx 🙏 |
|
Hello, sorry for the delay. I will check this weekend.
|
| `apache_polaris.sdk.catalog.models.LoadPolicyResponse`. | ||
|
|
||
| However, the generator fails to add the necessary `import` statements | ||
| to the `polaris/catalog/models/__init__.py` file. This means that even |
There was a problem hiding this comment.
polaris/catalog/models/__init__.py is now outdated with this PR. Change to apache_polaris/sdk/catalog/models/__init__.py
There was a problem hiding this comment.
Sure, good catch! I need to double-check all places properly 👍
| `apache_polaris.sdk.catalog.models.LoadPolicyResponse`. | ||
|
|
||
| However, the generator fails to add the necessary `import` statements | ||
| to the `polaris/catalog/models/__init__.py` file. This means that even |
There was a problem hiding this comment.
Path polaris/catalog/models/__init__.py is outdated. Change to apache_polaris/sdk/catalog/models/__init__.py
@binarycat0 nice work and thanks for the coordination on the dev ML. |
- reorganize python package catalogs - union all submodules (cli, polaris) under apache_polaris module - put polaris generated context into apache_polaris/sdk - make apache_polaris as a main module
15c0342 to
d97136e
Compare
|
Hello @MonkeyCanCode 👋, thank you for the review. I fixed the mentioned NIT comments, thanks. Also, the mentioned string splitters by () is caused by automatically formatting or by In my experience an applying "isort + mypy + black" linting was by default, I would like suggest following the same standard as many python projects.
|
Thanks for the quick fix. One of the minor comment was not fixed. Other than that, this looks good to me. @eric-maynard @HonahX , do u mind also take a look when u have a chance? |
|
@MonkeyCanCode Thank you again. I double-checked all places, now it should be good. |
|
Hello colleagues 👋 Can we make it merged? |
* chore(enhancement): rename python package to apache-polaris (apache#2812) - reorganize python package catalogs - union all submodules (cli, polaris) under apache_polaris module - put polaris generated context into apache_polaris/sdk - make apache_polaris as a main module * Update dependency pip-licenses-cli to v3.0.1 (apache#2996) * docs: Add quickstart documentation (apache#2976) * Add quickstart documentation targeting CLI convenience Co-authored-by: Alexandre Dutra <[email protected]> * Update dependency io.quarkus to v3.29.1 (apache#2985) * Add getting started docs for Apache Ozone (apache#2989) Closes apache#2207 * Add note on appendConfigOption Helm template explaining its logic (apache#2995) This has come up a few times as the logic is a bit surprising for people familiar with Helm templates. * fix(deps): update dependency io.micrometer:micrometer-bom to v1.16.0 (apache#3001) * chore(deps): update quay.io/keycloak/keycloak docker tag to v26.4.4 (apache#3002) * fix(deps): update dependency io.smallrye.common:smallrye-common-annotation to v2.14.0 (apache#3003) * NoSQL: Add Mongo database backend (apache#2992) * NoSQL: Add Mongo database backend This change adds the MongoDB specific `MongoDbBackend` implementation. Test cases inherited from the database agnostic `AbstractPersistenceTests` for `Backend` implementations, running against a testcontainer running Mongo. * bump mongo container version * NoSQL: "standalone" `Persistence` configuration helper (apache#2993) This change adds a utility module used in follow-up PRs like JMH based micro-benchmarks and correctness-tests, running as "standalone" JVMs providing flexible configurability via explict smallrye-config usage. This allows running JMH and correctness tests against various deployment scenarios, even multi-node database backends without having to spin up a full server instance. In other words: targeted benchmarking and testing eliminating side effects potentially induced by other components. * NoSQL: Docker-compose example for customized testing (apache#2994) * NoSQL: Docker-compose example for customized testing Upcoming PRs bring JMH based benchmarking and correctness testing. This change adds a docker-compose on how to spin up a 3 node MongoDB instance useable for the mentioned benchmarks/tests. * fix(deps): update dependency com.google.errorprone:error_prone_core to v2.44.0 (apache#3004) * Make CallContextCatalogFactory request-scoped (apache#2972) note the only non-test usage spot is `IcebergCatalogHandler#initializeCatalog` and `IcebergCatalogHandler` is getting created by `IcebergCatalogAdapter` which is already `@RequestScoped`. * Last merged commit 6546689 --------- Co-authored-by: Artur Rakhmatulin <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Adam Christian <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Christopher Lambert <[email protected]>
cli,polaris) underapache_polarismodulepolarisgenerated context intoapache_polaris/sdkapache_polarisas a main moduleFixes: #2699
What changes were proposed in this pull request?
Package name
As discussed in the mailing list thread, the majority agreed that a more suitable and compliant name would be
apache-polarisaccording to the Apache Distribution guideCatalogs structure
It would be beneficial to modify the directory structure. The current setup can lead to conflicts after package installation because it doesn't create a parent directory to group all apache-polaris related modules together. Instead, it directly places the cli and polaris directories into the root
.../site-packagesof the active environment.In the structure I am proposing, all modules related to the project will be placed in the
apache_polarismodule and will be available for use in code through import apache_polaris.sdk.catalog, apache_polaris.sdk.management and import apache_polaris.cli respectively.Why are the changes needed?
Initial Issue: #2419
Follow up Issue: #2699
Does this PR introduce any user-facing change?
How was this patch tested?
CHANGELOG.md