Add a configuration to optionally disable drop with purge#270
Merged
RussellSpitzer merged 9 commits intoapache:mainfrom Sep 9, 2024
Merged
Add a configuration to optionally disable drop with purge#270RussellSpitzer merged 9 commits intoapache:mainfrom
RussellSpitzer merged 9 commits intoapache:mainfrom
Conversation
eric-maynard
requested review from
RussellSpitzer,
ashvina,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
dennishuo
reviewed
Sep 5, 2024
Contributor
dennishuo
left a comment
dennishuo
left a comment
There was a problem hiding this comment.
A couple minor things, but high level intent looks good to me
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManagerImpl.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java
Outdated
Show resolved
Hide resolved
dennishuo
reviewed
Sep 5, 2024
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManagerImpl.java
Outdated
Show resolved
Hide resolved
dennishuo
approved these changes
Sep 5, 2024
Contributor
dennishuo
left a comment
dennishuo
left a comment
There was a problem hiding this comment.
A unittest case in BasePolarisCatalogTest could be handy to verify the catalog config override kicking in as expected.
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
Outdated
Show resolved
Hide resolved
sfc-gh-dhuo
approved these changes
Sep 9, 2024
RussellSpitzer
approved these changes
Sep 9, 2024
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Approved based on @dennishuo 's Review - Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Purging data with background tasks may not be reliable in the even that the Polaris service shuts down before it's able to complete the tasks.
Fixes #269
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.