Introduce operation CREATE_TABLE_DIRECT_WITH_WRITE_DELEGATION#27
Merged
dennishuo merged 10 commits intoapache:mainfrom Jul 31, 2024
Merged
Introduce operation CREATE_TABLE_DIRECT_WITH_WRITE_DELEGATION#27dennishuo merged 10 commits intoapache:mainfrom
dennishuo merged 10 commits intoapache:mainfrom
Conversation
dennishuo
reviewed
Jul 31, 2024
Contributor
dennishuo
left a comment
dennishuo
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Approach generally LGTM.
A couple test items that might be helpful to add:
- Looks like we lacked coverage of
createTableDirectWithWriteDelegationinPolarisCatalogHandlerWrapperAuthzTestoriginally, which ideally can serve as "tests-as-documentation" for the authz model; you could add two test cases that mimictestCreateTableStagedWithWriteDelegationAllSufficientPrivilegesandtestCreateTableStagedWithWriteDelegationInsufficientPermissionsto solidify that having havingTABLE_CREATEby itself is insufficient. (FollowtestCreateTableStagedAllSufficientPrivilegesfor the cleanup hook) - Update
test_spark_credentials_s3_direct_without_readas well
polaris-core/src/main/java/io/polaris/core/auth/PolarisAuthorizableOperation.java
Outdated
Show resolved
Hide resolved
kevinjqliu
pushed a commit
to kevinjqliu/polaris
that referenced
this pull request
Jul 31, 2024
* Add issue templates * Add color to PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new operation,
CREATE_TABLE_DIRECT_WITH_WRITE_DELEGATION, and requires it forcreateTableDirectWithWriteDelegation.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a new test in
test_spark_sql_s3_with_privileges.pyChecklist:
Please delete options that are not relevant.