Fixing links (new PR for approved PR #136 after rebasing)#231
Closed
jaret-basden wants to merge 0 commit intoapache:mainfrom
Closed
Fixing links (new PR for approved PR #136 after rebasing)#231jaret-basden wants to merge 0 commit intoapache:mainfrom
jaret-basden wants to merge 0 commit intoapache:mainfrom
Conversation
jbonofre
reviewed
Aug 30, 2024
Member
jbonofre
left a comment
There was a problem hiding this comment.
Overall ok, I just left a comment about polaris.io linking.
docs/command-line-interface.md
Outdated
Member
There was a problem hiding this comment.
I think it would be better to wait the documentation moved to polaris.apache.org (else we will have to change again).
Even if polaris.io will redirect to polaris.apache.org, I think it's cleaner to directly link to polaris.apache.org.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This PR is a new PR for PR #136 Fixing links. PR #136 has already been approved. Per RussellSpitzer's comment in PR #136, I rebased. Correct me if I'm wrong but it appears now I need to open a new PR to merge the changes.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue): N/A
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
Please delete options that are not relevant.