Add Docker images SNAPSHOT on Docker HUB (nightly) by jbonofre · Pull Request #1593 · apache/polaris

jbonofre · 2025-05-15T07:45:53Z

As discussed on the mailing list, this PR extends nightly build to push SNAPSHOT images on Docker HUB.

adutra

@jbonofre thanks for driving this, it will be very useful!

Global suggestion: I would change the image names and tags in order to not mix up release images with nightly images:

      - name: Build Server Docker image
        run: |
          ./gradlew \
            :polaris-quarkus-server:assemble \
            :polaris-quarkus-server:quarkusAppPartsBuild --rerun \
            -Dquarkus.container-image.build=true \
            -Dquarkus.container-image.push=true \
            -Dquarkus.container-image.name=polaris-nightly \
            -Dquarkus.container-image.tag=$(date +%Y%m%d) \
            -Dquarkus.container-image.additional-tags=""
      - name: Build Admin Tool Docker image
        run: |
          ./gradlew \
            :polaris-quarkus-admin:assemble \
            :polaris-quarkus-admin:quarkusAppPartsBuild --rerun \
            -Dquarkus.container-image.build=true \
            -Dquarkus.container-image.push=true \
            -Dquarkus.container-image.name=polaris-admin-tool-nightly \
            -Dquarkus.container-image.tag=$(date +%Y%m%d) \
            -Dquarkus.container-image.additional-tags=""

.github/workflows/nightly.yml

adutra · 2025-05-15T13:14:18Z

.github/workflows/nightly.yml

This is only pushing the server image, not the admin tool image.

@adutra Thanks for the suggestion. I was planning to push only the server image, but it makes sense to push both. Then, it makes sense to use different docker image name. I will update this PR accordingly. Thanks !

@adutra I'm not sure using nightly in the image name is good there. I would prefer in the version/tag. Thoughts ?

I'm fine either way, as long as you don't use latest for that.

By the way, in apache DockerHub scope, we can only have polaris as image name for now. We can ask to create another apache/polaris-admin-tool repo. However, I think it's fine to use tag/version like admin-tool-xxxx. It's what I'm doing for the release for now.
OK ?

Hmm not really :-) we shouldn't mix different binaries under the same image name.

OK, so for now let's push only server image (polaris). Do you want me to already create apache/polaris-admin-tool repo ?

I'm fine with pushing just the server for now. If the process to create apache/polaris-admin-tool takes time, I'd say let's start it asap.

Let's start a discussion on the dev mailing list.

adutra · 2025-05-30T12:24:19Z

Heads up: it would be nice to publish multi-platform images. This can be done with Quarkus + Docker, but one needs to build and push the images at the same time, e.g.

./gradlew \
    :polaris-quarkus-server:assemble \
    :polaris-quarkus-server:quarkusAppPartsBuild --rerun \
    -Dquarkus.docker.buildx.platform=linux/amd64,linux/arm64 \
    -Dquarkus.container-image.build=true \
    -Dquarkus.container-image.push=true \
    -Dquarkus.container-image.name=polaris-nightly \
    -Dquarkus.container-image.tag=$(date +%Y%m%d) \
    -Dquarkus.container-image.additional-tags=""

The same should be done for release images, if possible.

jbonofre · 2025-05-31T04:27:59Z

@adutra yes, that's a good point. For 0.10 I did only linux/amd64 image. Let me update the release guide with multi-platform instructions.

flyrain · 2025-06-10T22:53:05Z

Can we move forward with this PR? I'm OK to merge the server image first, or combine it with admin-tool image.

.github/workflows/nightly.yml

snazy · 2025-07-12T10:23:26Z

.github/workflows/nightly.yml

Nit: you could use latest here (and below)

If the repository + image name are the same as the ones used for releases, it's safer to not use latest for nightlies.

I recall this ML discussion:

https://lists.apache.org/thread/nr4bw27zyfsr0cc0cn34h1yq0d1t01f7

There wasn't a formal consensus there, but the emerging idea would be to use the nightly tag, rather than a timestamp, to avoid accumulation of tags.

Ah, I missed that this publishes to the only repo. I asumed, that this one publishes to a *-nightlies repo.

Feels much safer to publish to a separate repo to clearly separate releases from snapshots/nightlies, also to not confuse renovate/dependabot.

I'm not fan at all of a separate repo for nightly/snapshots.
I think it's better for user to just use the same repo with a specific tag format.

I'm ok to use nightly instead of date.

I updated to use nightly as tag/version.

IIRC we discussed the cons of using one repo, as new tags will confuse renovate and dependabot.
I think, we have to direct users to "proper" releases, not to nightlies or snapshots.

Reading Renovate's doc, it seems it is smart enough to never update a x.y.z tag to a nightly tag:

If the image tag in use "looks" like a version (e.g. myimage:1, myimage:1.1, myimage:1.1.0, myimage:1-onbuild) then Renovate checks the Docker registry for upgrades (e.g. from myimage:1.1.0 to myimage:1.2.0)

The above seems to imply that the nightly tag would be ignored since it doesn't "look like" a version.

But I didn't verify if that's indeed the case.

jbonofre requested review from HonahX, MonkeyCanCode, RussellSpitzer, adutra, ashvina, collado-mike, dennishuo, dimas-b, ebyhr, eric-maynard, flyrain, jackye1995, singhpk234, snazy, takidau and vvcephei as code owners May 15, 2025 07:45

github-project-automation bot added this to Basic Kanban Board May 15, 2025

jbonofre requested a review from pingtimeout as a code owner May 15, 2025 07:45

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board May 15, 2025

adutra reviewed May 15, 2025

View reviewed changes

adnanhemani mentioned this pull request May 15, 2025

Push Docker Images on New Release #1377

Closed

jbonofre force-pushed the nightly-docker branch from c0ea0bd to 98094d4 Compare June 20, 2025 09:21

jbonofre force-pushed the nightly-docker branch from 98094d4 to 99c7a84 Compare July 12, 2025 09:51

snazy reviewed Jul 12, 2025

View reviewed changes

.github/workflows/nightly.yml Outdated Show resolved Hide resolved

snazy reviewed Jul 12, 2025

View reviewed changes

Add Docker nightly images publication on Docker HUB

9112f43

jbonofre force-pushed the nightly-docker branch from 99c7a84 to 9112f43 Compare July 14, 2025 08:24

adutra mentioned this pull request Jul 15, 2025

Remove postgres_latest as image tag #2045

Merged

Conversation

jbonofre commented May 15, 2025

Uh oh!

adutra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adutra commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbonofre commented May 31, 2025

Uh oh!

flyrain commented Jun 10, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adutra commented May 30, 2025 •

edited

Loading