You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fangd1997
changed the title
fix _getText in XWPFRun
fix _getText in XWPFRun(ignore w:delInstrText, convert w:noBreakHyphen)
Aug 12, 2024
fangd1997
changed the title
fix _getText in XWPFRun(ignore w:delInstrText, convert w:noBreakHyphen)
XWPF: fix _getText in XWPFRun(ignore w:delInstrText, convert w:noBreakHyphen)
Aug 12, 2024
fangd1997
changed the title
XWPF: fix _getText in XWPFRun(ignore w:delInstrText, convert w:noBreakHyphen)
XWPF: fix _getText in XWPFRun(ignore w:delInstrText, convert w:noBreakHyphen to "‑")
Aug 12, 2024
It is my understanding that noBreakHyphens are displayed optionally - if, for instance, you display a paragraph in a narrow space. Most people extracting this text will have no interest in seeing the hyphen. For me, this behaviour would have to be optional and default to the existing behaviour.
For delInstrText, please provide a sample docx file that can be used to test with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pjfanning Please help review the code