Skip to content

POIXMLProperties: add setters for ExtendedProperties, like other classes#157

Closed
dourouc05 wants to merge 3 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-extendedproperties
Closed

POIXMLProperties: add setters for ExtendedProperties, like other classes#157
dourouc05 wants to merge 3 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-extendedproperties

Conversation

@dourouc05
Copy link
Copy Markdown

@dourouc05 dourouc05 commented Jun 25, 2019

…ses.

@asfgit
Copy link
Copy Markdown

asfgit commented Jun 25, 2019

Can one of the admins verify this patch?

pjfanning
pjfanning requested changes Jul 16, 2019
View reviewed changes
@dourouc05
Copy link
Copy Markdown
Author

dourouc05 commented Jul 19, 2019

@pjfanning better this way?

@pjfanning
Copy link
Copy Markdown
Member

pjfanning commented Jul 19, 2019

The new test fails:

        FAILED
expected null, but was:<Apache POI>
junit.framework.AssertionFailedError: expected null, but was:<Apache POI>
        at org.apache.poi.ooxml.TestPOIXMLProperties.testWorkbookExtendedPropertiesGettersSetters(TestPOIXMLProperties.java:131)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@asfgit asfgit closed this in ec60bea Jul 19, 2019
@pjfanning
Copy link
Copy Markdown
Member

pjfanning commented Jul 19, 2019

I fixed the test and merged with https://svn.apache.org/repos/asf/poi/trunk@1863432

asfgit pushed a commit that referenced this pull request Oct 6, 2019
@pjfanning
[github-157] add setters for ExtendedProperties. Thanks to Thibaut Cu…
10b5a46 
…velier. This closes #157

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863432 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez pushed a commit to cuali/poi that referenced this pull request Dec 12, 2019
[github-157] add setters for ExtendedProperties. Thanks to Thibaut Cu…
51b1ad5 
…velier. This closes apache#157

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863432 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjfanning pjfanning pjfanning requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dourouc05 @asfgit @pjfanning