XWPFPicture: easy access to width and depth#150
Closed
dourouc05 wants to merge 4 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-xwpfpicture
Closed
XWPFPicture: easy access to width and depth#150dourouc05 wants to merge 4 commits intoapache:trunkfrom dourouc05:dourouc05-patch-xwpfpicture
dourouc05 wants to merge 4 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-xwpfpicture
Conversation
|
Can one of the admins verify this patch? |
| } | ||
|
|
||
| /** | ||
| * Returns the width of the picture (in EMU). |
Contributor
There was a problem hiding this comment.
width was copied from above.
Most of the other API use Units.toPoints() to convert out of EMU to more human understandable points.
Author
|
I've just added a test for the new methods. Is this enough for merging? |
Author
|
@pjfanning @Alain-Bearez is this OK to merge? |
asfgit
pushed a commit
that referenced
this pull request
Oct 6, 2019
…hibaut Cuvelier. This closes #150 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863434 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…hibaut Cuvelier. This closes apache#150 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863434 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suppose adding a test case wouldn't hurt (something like calling XWPFRun.addPicture then calling these two new methods).
(BTW, would a pull request to add an overload to XWPFRun.addPicture be accepted? It would be to compute the width and depth from the input file, using javax.ImageIO -- an acceptable dependency or not?)