[github-176] Remove limit on number of rules in XSSFSheetConditionalFormatting. This closes #176

pjfanning · pjfanning · commit 4da2b597e065 · 2020-04-29T20:26:09.000Z
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1877175 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheetConditionalFormatting.java
@@ -132,17 +132,17 @@ public XSSFConditionalFormattingRule createConditionalFormattingRule(String form
      */
     public XSSFConditionalFormattingRule createConditionalFormattingRule(XSSFColor color) {
         XSSFConditionalFormattingRule rule = new XSSFConditionalFormattingRule(_sheet);
-        
+
         // Have it setup, with suitable defaults
         rule.createDataBarFormatting(color);
-        
+
         // All done!
         return rule;
     }
     public XSSFConditionalFormattingRule createConditionalFormattingRule(ExtendedColor color) {
         return createConditionalFormattingRule((XSSFColor)color);
     }
-    
+
     /**
      * A factory method allowing the creation of conditional formatting
      *  rules using an Icon Set / Multi-State formatting.
@@ -154,10 +154,10 @@ public XSSFConditionalFormattingRule createConditionalFormattingRule(ExtendedCol
      */
     public XSSFConditionalFormattingRule createConditionalFormattingRule(IconSet iconSet) {
         XSSFConditionalFormattingRule rule = new XSSFConditionalFormattingRule(_sheet);
-        
+
         // Have it setup, with suitable defaults
         rule.createMultiStateFormatting(iconSet);
-        
+
         // All done!
         return rule;
     }
@@ -174,14 +174,14 @@ public XSSFConditionalFormattingRule createConditionalFormattingRule(IconSet ico
      */
     public XSSFConditionalFormattingRule createConditionalFormattingColorScaleRule() {
         XSSFConditionalFormattingRule rule = new XSSFConditionalFormattingRule(_sheet);
-        
+
         // Have it setup, with suitable defaults
         rule.createColorScaleFormatting();
-        
+
         // All done!
         return rule;
     }
-    
+
     public int addConditionalFormatting(CellRangeAddress[] regions, ConditionalFormattingRule[] cfRules) {
         if (regions == null) {
             throw new IllegalArgumentException("regions must not be null");
@@ -194,9 +194,6 @@ public int addConditionalFormatting(CellRangeAddress[] regions, ConditionalForma
         if (cfRules.length == 0) {
             throw new IllegalArgumentException("cfRules must not be empty");
         }
-        if (cfRules.length > 3) {
-            throw new IllegalArgumentException("Number of rules must not exceed 3");
-        }
 
         CellRangeAddress[] mergeCellRanges = CellRangeUtil.mergeCellRanges(regions);
         CTConditionalFormatting cf = _sheet.getCTWorksheet().addNewConditionalFormatting();
@@ -218,22 +215,22 @@ public int addConditionalFormatting(CellRangeAddress[] regions, ConditionalForma
     }
 
     public int addConditionalFormatting(CellRangeAddress[] regions,
-            ConditionalFormattingRule rule1)
+                                        ConditionalFormattingRule rule1)
     {
         return addConditionalFormatting(regions,
                 rule1 == null ? null : new XSSFConditionalFormattingRule[] {
-                (XSSFConditionalFormattingRule)rule1
-        });
+                        (XSSFConditionalFormattingRule)rule1
+                });
     }
 
     public int addConditionalFormatting(CellRangeAddress[] regions,
-            ConditionalFormattingRule rule1, ConditionalFormattingRule rule2)
+                                        ConditionalFormattingRule rule1, ConditionalFormattingRule rule2)
     {
         return addConditionalFormatting(regions,
                 rule1 == null ? null : new XSSFConditionalFormattingRule[] {
-                    (XSSFConditionalFormattingRule)rule1,
-                    (XSSFConditionalFormattingRule)rule2
-            });
+                        (XSSFConditionalFormattingRule)rule1,
+                        (XSSFConditionalFormattingRule)rule2
+                });
     }
 
     /**
@@ -256,29 +253,29 @@ public int addConditionalFormatting( ConditionalFormatting cf ) {
     }
 
     /**
-    * gets Conditional Formatting object at a particular index
-    *
-    * @param index
-    *			of the Conditional Formatting object to fetch
-    * @return Conditional Formatting object
-    */
+     * gets Conditional Formatting object at a particular index
+     *
+     * @param index
+     *			of the Conditional Formatting object to fetch
+     * @return Conditional Formatting object
+     */
     public XSSFConditionalFormatting getConditionalFormattingAt(int index) {
         checkIndex(index);
         CTConditionalFormatting cf = _sheet.getCTWorksheet().getConditionalFormattingArray(index);
         return new XSSFConditionalFormatting(_sheet, cf);
     }
 
     /**
-    * @return number of Conditional Formatting objects of the sheet
-    */
+     * @return number of Conditional Formatting objects of the sheet
+     */
     public int getNumConditionalFormattings() {
         return _sheet.getCTWorksheet().sizeOfConditionalFormattingArray();
     }
 
     /**
-    * removes a Conditional Formatting object by index
-    * @param index of a Conditional Formatting object to remove
-    */
+     * removes a Conditional Formatting object by index
+     * @param index of a Conditional Formatting object to remove
+     */
     public void removeConditionalFormatting(int index) {
         checkIndex(index);
         _sheet.getCTWorksheet().removeConditionalFormatting(index);
@@ -292,4 +289,4 @@ private void checkIndex(int index) {
         }
     }
 
-}
+}
