Adding configs for zk client timeout #9975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
added
release-notes
xiangfu0
force-pushed
the
zk_client_timeout
branch
2 times, most recently
from
8d5661b to
eed7472
Compare
elonazoulay
approved these changes
Dec 12, 2022
Jackie-Jiang
approved these changes
Dec 12, 2022
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/controller/helix/core/realtime/PinotRealtimeSegmentManager.java
Outdated
Show resolved
Hide resolved
jackjlli
approved these changes
Dec 12, 2022
xiangfu0
force-pushed
the
zk_client_timeout
branch
from
eed7472 to
8d8986e
Compare
xiangfu0
force-pushed
the
zk_client_timeout
branch
from
8d8986e to
d6a35e7
Compare
…and some other cases (apache#9950)" This reverts commit 6a5f58b.
xiangfu0
force-pushed
the
zk_client_timeout
branch
from
cb7cbd9 to
4ebf656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to config zookeeper timeout using configuration:
zk.client.session.timeout.ms: default to 30 secszk.client.connection.timeout.ms: default to 60 secsNote that, this is only used by pinot side ZK ops, like setup cluster structure, realtime table/segments management, not related to Helix ZK configs.
For helix zk client configs, we need to set System Properties like:
zk.session.timeout,zk.connection.timeout