#9834 Added Delete Schema/Table pinot admin commands #9857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9857 +/- ##
=============================================
- Coverage 70.34% 28.27% -42.08%
+ Complexity 5014 53 -4961
=============================================
Files 1972 1960 -12
Lines 105692 105418 -274
Branches 15993 15993
=============================================
- Hits 74350 29806 -44544
- Misses 26137 72691 +46554
+ Partials 5205 2921 -2284
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Nov 28, 2022
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
LGTM otherwise. I'd be good if we can add a test for them
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
added
the
release-notes
Contributor
|
Can you please also add some documentation for the new command here: https://docs.pinot.apache.org/basics/components/table#using-launcher-scripts |
bagipriyank
force-pushed
the
issue-9834
branch
from
8048a6b to
e969275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9834