Add record availability lag for Kafka connector #9621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navina
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9621 +/- ##
============================================
- Coverage 35.02% 34.95% -0.08%
Complexity 189 189
============================================
Files 1943 1943
Lines 103817 103841 +24
Branches 15743 15744 +1
============================================
- Hits 36361 36293 -68
- Misses 64369 64448 +79
- Partials 3087 3100 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
navina
force-pushed
the
availability-lag
branch
from
b13c20f to
5690659
Compare
Contributor
Author
navina
force-pushed
the
availability-lag
branch
from
5690659 to
2b4a535
Compare
Jackie-Jiang
added
feature
release-notes
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionLagState.java
Outdated
Show resolved
Hide resolved
navina
force-pushed
the
availability-lag
branch
from
2b4a535 to
16ca0d8
Compare
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Try to keep the json property and variable name the same
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/api/resources/DebugResource.java
Outdated
Show resolved
Hide resolved
...ka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java
Outdated
Show resolved
Hide resolved
...afka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerPartitionLag.java
Outdated
Show resolved
Hide resolved
...afka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerPartitionLag.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java
Outdated
Show resolved
Hide resolved
Contributor
|
We may also pick a shorter name for them to be more concise, but let's keep the name consistent across classes:
|
navina
force-pushed
the
availability-lag
branch
from
16ca0d8 to
1784131
Compare
navina
force-pushed
the
availability-lag
branch
from
86af551 to
f374edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces record availability lag for realtime connectors via the rest apis -
consumingSegmentsInfoand
/debug/tables/{tableName}Label:
release-notes/consumingSegmentsInfoanddebug/tables/{tableName}API now provides the following per-partition numbers for Kafka data sources:currentConsumingOffset,latestUpstreamOffset,recordsLag,availabilityLagMs