-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add SegmentTierAssigner and refine restful APIs to get segment tier info #9598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9598 +/- ##
=============================================
+ Coverage 25.84% 69.89% +44.04%
- Complexity 44 4977 +4933
=============================================
Files 1926 1939 +13
Lines 103305 103725 +420
Branches 15688 15739 +51
=============================================
+ Hits 26702 72497 +45795
+ Misses 73903 26119 -47784
- Partials 2700 5109 +2409
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1f252e0 to
57a1203
Compare
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
...ler/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentTierAssigner.java
Outdated
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
Outdated
Show resolved
Hide resolved
1a900e0 to
55a9458
Compare
npawar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add an example to the PR description, regarding the changes expected to the the API response
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableTierReader.java
Outdated
Show resolved
Hide resolved
0b36a80 to
4824266
Compare
npawar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR is part of the work to support multi-datadir for Pinot server as tracked by #8843.
Following up on #9306, this one adds the controller side periodic task SegmentTierAssigner to calculate the target tier for segment and set it in SegmentZKMetadata, as goal state to guide servers to put segments into the right datadir (i.e. tier).
The next PR will connect the two parts, i.e. reusing SegmentReloadMessage to notify servers to do the migration.
Release Note
New configs to turn on tier assigner:
Extended API to query segment tiers