get task runtime configs tracked in Helix #9540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhtaoxiang
reviewed
Oct 5, 2022
...c/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
Show resolved
Hide resolved
...roller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9540 +/- ##
============================================
- Coverage 69.86% 63.69% -6.17%
- Complexity 4795 4848 +53
============================================
Files 1927 1874 -53
Lines 102697 100401 -2296
Branches 15586 15317 -269
============================================
- Hits 71747 63951 -7796
- Misses 25878 31741 +5863
+ Partials 5072 4709 -363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhtaoxiang
approved these changes
Oct 6, 2022
Jackie-Jiang
approved these changes
Oct 6, 2022
...c/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a restful API to get task runtime configs like concurrencyPerWorker and taskTimeout. Note that those are not inside the subtasks' configs. Also refine some logs found useful when debugging minion related APIs.
Release Note
/tasks/task/{taskName}/runtime/config: a new restful API added on controller to get task runtime configs like subtask concurrency per worker and task timeout