Always store time in zookeeper metadata in milliseconds #9472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9472 +/- ##
============================================
- Coverage 69.89% 63.61% -6.28%
- Complexity 4742 5109 +367
============================================
Files 1910 1857 -53
Lines 101787 99477 -2310
Branches 15445 15178 -267
============================================
- Hits 71139 63286 -7853
- Misses 25628 31536 +5908
+ Partials 5020 4655 -365
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Suggest making the change in ZKMetadataUtils.updateSegmentZKMetadata() for now. That way even if we push old generated segment, we will still get the millis start/end time. Currently SegmentMetadataImpl._timeGranularity relies on the time unit, so if we want to change the time unit in segment metadata, we want to clean it up to prevent unexpected behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if time format is EPOCH. we store the time metadata in zookeeper in the timeUnit specified in the format. e.g for
1:EPOCH:SECONDSwe will store time in seconds.This only increases complexity while processing metadata and also uses extra space in zookeeper to store timeUnit String for each segment.
The PR aims to make a small change to always store time in milliseconds. The TimeUnit hasn't been removed from Zookeeper so as to maintain backward compatibility.